Enhance Filters (Invoke-FGTRestMethod) by Tuurtje · Pull Request #95 · FortiPower/PowerFGT

Tuurtje · 2020-04-10T08:25:26Z

There was something wrong with the parameter sets. Somehow they need to be on the same line as "mandatory", else all options are visible in every parameterset.

Also added the remaining filter type's (because i needed them).

notequal, notcontains, less, lessorequal, greater, greaterorequal added. Non-working parameterset fixed. Old Syntax output: SYNTAX Invoke-FGTRestMethod [-uri] <String> [-method <String>] [-body <PSObject>] [-skip] [-vdom <String[]>] [-filter <String>] [-filter_attribute <String>] [-filter_type <String>] [-filter_value <PSObject>] [-connection <PSObject>] [<CommonParameters>] Invoke-FGTRestMethod [-uri] <String> [-method <String>] [-body <PSObject>] [-skip] [-vdom <String[]>] [-filter <String>] [-filter_attribute <String>] [-filter_type <String>] [-filter_value <PSObject>] [-connection <PSObject>] [<CommonParameters>] Invoke-FGTRestMethod [-uri] <String> [-method <String>] [-body <PSObject>] [-skip] [-vdom <String[]>] [-filter <String>] [-filter_attribute <String>] [-filter_type <String>] [-filter_value <PSObject>] [-connection <PSObject>] [<CommonParameters>] New Syntax output: SYNTAX Invoke-FGTRestMethod [-uri] <String> [-method <String>] [-body <PSObject>] [-skip] [-vdom <String[]>] [-connection <PSObject>] [<CommonParameters>] Invoke-FGTRestMethod [-uri] <String> [-method <String>] [-body <PSObject>] [-skip] [-vdom <String[]>] [-filter <String>] [-connection <PSObject>] [<CommonParameters>] Invoke-FGTRestMethod [-uri] <String> [-method <String>] [-body <PSObject>] [-skip] [-vdom <String[]>] [-filter_attribute <String>] [-filter_type <String>] [-filter_value <PSObject>] [-connection <PSObject>] [<CommonParameters>]

alagoutte · 2020-04-10T09:25:02Z

Hi Arthur,

Thanks, All Filter work ?!

Yes, it is strange for filter... (i really need to add some test...)

Tuurtje · 2020-04-10T09:36:06Z

Yeah tested them all. they all seem to work.

alagoutte · 2020-04-10T11:34:13Z

Thanks, i will check !

alagoutte · 2020-04-10T12:19:15Z

PowerFGT/Public/cmdb/firewall/address.ps1

-        [Parameter (Mandatory = $false)]
-        [Parameter (ParameterSetName = "filter")]
+        [Parameter(Mandatory = $false, ParameterSetName = "filter")]
+        [String]$filter,


i don't really like the idea to have directly filter parameter.. but prefer we can build filter with filter_type, attribute...

Oke i will remove it. Advanced searches can be done with invoke-FGTRestMothode if needed. is the parameter name-change (filter -> filter_build) oke? This will make it consistant with Invoke-FGTRestMethode. If not i will change it back.

Ok for change ParameterName

alagoutte · 2020-04-14T08:16:03Z

Thanks Arthur, can you add name of file on commit message ?
ippool: Fixed ParameterSets and added filter types

for example (or make a big commit with all change)
it is very strange, i don't work if you set the parametername outside of first Parameter

Tuurtje · 2020-04-14T08:35:51Z

Will do next time. I made the same change in all file. Don't know how to do this in one commit.

…

________________________________ Van: Alexis La Goutte <notifications@github.com> Verzonden: dinsdag 14 april 2020 08:16 Aan: FortiPower/PowerFGT <PowerFGT@noreply.github.com> CC: Arthur Heijnen <arthur.heijnen@live.nl>; Author <author@noreply.github.com> Onderwerp: Re: [FortiPower/PowerFGT] Enhance Filters (Invoke-FGTRestMethod) (#95) Thanks Arthur, can you add name of file on commit message ? ippool: Fixed ParameterSets and added filter types for example (or make a big commit with all change) it is very strange, i don't work if you set the parametername outside of first Parameter — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#95 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABQAF77EKVSLJIWBZW4KOJDRMQLVFANCNFSM4MFJYI7A>.

alagoutte · 2020-04-14T08:56:41Z

What tools do you are using for git ?

only need to make a git add of all file (or use git commit -a) after make change all files

(you can also use git rebase -i master and reword/squash/fixup and after need to make a git push -f for force)

Tuurtje · 2020-04-14T09:00:14Z

Copy past in webbrowser :-( I've got github desktop installed. will check the howto.

…

________________________________ Van: Alexis La Goutte <notifications@github.com> Verzonden: dinsdag 14 april 2020 08:56 Aan: FortiPower/PowerFGT <PowerFGT@noreply.github.com> CC: Arthur Heijnen <arthur.heijnen@live.nl>; Author <author@noreply.github.com> Onderwerp: Re: [FortiPower/PowerFGT] Enhance Filters (Invoke-FGTRestMethod) (#95) What tools do you are using for git ? only need to make a git add of all file (or use git commit -a) after make change all files (you can also use git rebase -i master and reword/squash/fixup and after need to make a git push -f for force) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#95 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABQAF743VQ3NGDKMFAVPVSDRMQQNRANCNFSM4MFJYI7A>.

poundy · 2020-04-14T11:12:07Z

Copy past in webbrowser :-( I've got github desktop installed. will check the howto.
…
Welcome to that club :)
I'm waiting for the 0.5.0 release so I can get back to a state to test and tweak further because I started with copy/paste and not understanding pull requests :)

alagoutte · 2020-04-14T20:23:37Z

Hi sorry guys but busy for the moment for work on PowerFGT (need to finish 2 other module)
I hope get more time end of month and release a new version next month (i will add all external contribution and add tests integration)

I can help you, if you need for git skill

alagoutte · 2022-12-23T12:23:11Z

Hi Arthur

you can kept open it is always on my todo (but no really in the top !)

Tuurtje added 2 commits April 10, 2020 09:20

removed line from filter section

24e1179

alagoutte changed the title ~~Filters~~ Enhance Filters (Invoke-FGTRestMethod) Apr 10, 2020

Corrected parametersets and added remaining filter types

2f11b59

alagoutte reviewed Apr 10, 2020

View reviewed changes

Tuurtje added 6 commits April 14, 2020 09:37

Removed the direct filter option

e43973d

Fixed Parametersets and added extra types

b88782f

Fixed parametersets and added filter types

727d2a2

Update ippool.ps1

95836a7

Fixed parametersets and added filter types

9c4afff

Fixed parametersets and added filter types

5562f7d

Tuurtje closed this by deleting the head repository Dec 23, 2022

alagoutte reopened this Dec 23, 2022

Conversation

Tuurtje commented Apr 10, 2020

Uh oh!

alagoutte commented Apr 10, 2020

Uh oh!

Tuurtje commented Apr 10, 2020 via email • edited by alagoutte Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alagoutte commented Apr 10, 2020

Uh oh!

alagoutte Apr 10, 2020

Choose a reason for hiding this comment

Uh oh!

Tuurtje Apr 10, 2020

Choose a reason for hiding this comment

Uh oh!

alagoutte Apr 10, 2020

Choose a reason for hiding this comment

Uh oh!

alagoutte commented Apr 14, 2020

Uh oh!

Tuurtje commented Apr 14, 2020 via email

Uh oh!

alagoutte commented Apr 14, 2020

Uh oh!

Tuurtje commented Apr 14, 2020 via email

Uh oh!

poundy commented Apr 14, 2020

Uh oh!

alagoutte commented Apr 14, 2020

Uh oh!

alagoutte commented Dec 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Tuurtje commented Apr 10, 2020 via email •

edited by alagoutte

Loading