Refactor spec loader validation into shared helper and add schema-version tests#154
Merged
aidankhogg merged 1 commit intoJun 29, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
load_spec,load_spec_with_composition,load_spec_with_environment).Description
_validate_spec_data(data: dict[str, Any], *, validate_feature_states: bool) -> NetEngineSpecwhich performs type checks ondataandmetadata, rejects unsupportedmetadata.schema_version, constructsNetEngineSpec(**data), runs_cross_validate, and optionally_validate_feature_states.load_spec,load_spec_with_composition, andload_spec_with_environmentto only load/merge YAML dictionaries and then delegate validation to_validate_spec_data.SpecLoadErrormessages for schema-version rejection and other validation errors to keep test expectations stable.tests/test_config.pycovering schema-version rejection for all three loader paths (load_spec,load_spec_with_composition, andload_spec_with_environment).Testing
python -m py_compile netengine/spec/loader.pyran and succeeded to verify syntax correctness of the modified module.pytest tests/test_config.pywas attempted but could not run to completion due to an environment import error (ModuleNotFoundError: No module named 'logs') reported by test collection, so the new tests were added but not executed in this environment.Codex Task