Align DNS doctor ports with CoreDNS bindings#151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
COREDNS_PORT_BINDINGSandCOREDNS_PORTSconstants and update_deploy_corednsto expose and bind both53/udpand53/tcpusing these shared constants innetengine/handlers/dns.py.KnownPort(53, "tcp", "DNS")andKnownPort(53, "udp", "DNS")inKNOWN_LOCAL_PORTSand ensure the doctor checks remain required for both protocols innetengine/diagnostic/preflight.py._DNS_PORT_HINTto mention macOS with Docker Desktop, privileged host-port binding, and a configurable alternate DNS host port innetengine/diagnostic/preflight.py.tests/test_doctor.pythat assert the doctor’s required DNS ports matchCOREDNS_PORT_BINDINGSand that the updated port-53 hint contains the macOS/Docker Desktop guidance.Testing
python -m pytest tests/test_doctor.py -q, and the test suite completed successfully (17 passed).ruffon the modified files and they passed with no issues.Codex Task