Add step CLI version check and improve PKI initialization#108
Merged
Conversation
- Remove unsupported '--ip' flag from step ca init command (newer step versions don't support this flag; IP assignment is handled by Docker networking) - Improve error diagnostics in PKI handler with detailed logging of step command invocation and failure reasons - Add step CLI version check to preflight diagnostics for early detection of PKI compatibility issues - Better error messages guide users when step CLI is missing or incompatible Fixes Phase 3 PKI initialization failure with newer step-ca images that removed the --ip flag. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YZeM5c3NRxL5jVCNGtbcCD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds diagnostic checking for the step CLI tool and improves error handling and logging in PKI initialization. The changes ensure better visibility into PKI setup issues and provide clearer guidance when step CLI is unavailable or incompatible.
Key Changes
_check_step_version()diagnostic probe that verifies step CLI availability and reports its version. This check is non-required and will skip gracefully if step is not found.--ipflag: Removed the--ipflag from thestep ca initcommand as it's not supported in newer step versions. Docker networking now handles IP assignment instead.--ipflag.Implementation Details
shutil.which()to locate the step CLI and runsstep versionto verify it's workinghttps://claude.ai/code/session_01YZeM5c3NRxL5jVCNGtbcCD