feat: add differentiated Cache-Control headers to stream list responses#273
Open
devEunicee wants to merge 1 commit into
Open
feat: add differentiated Cache-Control headers to stream list responses#273devEunicee wants to merge 1 commit into
devEunicee wants to merge 1 commit into
Conversation
|
@devEunicee Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sets differentiated
Cache-Controlheaders onGET /api/streamsandGET /api/streams/:idbased on the mutability of the returned stream data.Changes
src/streams/status.ts— addisTerminalStatus(status: ApiStreamStatus): booleanhelpersrc/routes/streams.ts— derive and setCache-Controlbeforeres.jsonin both GET handlerstests/routes/streams.cacheControl.test.ts— 12 tests (all passing): active/paused/scheduled → no-store, completed/cancelled → cacheable, mixed page → no-store, empty page → cacheabledocs/api.md— document caching behaviour per stream statusCache-Control logic
active,paused, orscheduledprivate, no-storecompletedorcancelledpublic, max-age=300, stale-while-revalidate=60public, max-age=300, stale-while-revalidate=60Terminal streams are immutable — safe to cache at the edge. Non-terminal streams carry live financial state that changes continuously and must not be stored by shared caches.
Test results
Closes #234