docker-publish: add MI210 (gfx90a) and MI300 (gfx942) image builds#130
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
fluidnumericsJoe
force-pushed
the
feature/docker-publish-amd
branch
from
3ea7dac to
dbaf18c
Compare
Add double- and single-precision MI210 (gfx90a) variants to the docker-publish matrix, and wire the SELF_DOUBLE_PRECISION build arg into the x86_gfx90a Dockerfile so the single-precision variant builds correctly. The MI300X (gfx942) and NVIDIA variants previously included on this branch are already on main via #132, so only the new gfx90a builds remain here. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
fluidnumericsJoe
force-pushed
the
feature/docker-publish-amd
branch
from
dbaf18c to
0270edd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the
docker-publishmatrix beyond the single CUDAsm_100variant so the AMD CDNA targets are published tohigherordermethods/selfalongside it.x86-cuda130-sm100(B300)docker/x86_sm100selfish:latest-x86-cuda130-sm100x86-rocm643-gfx90a(MI210)docker/x86_gfx90aselfish:latest-x86-rocm643-gfx90ax86-rocm643-gfx942(MI300X)docker/x86_gfx942selfish:latest-x86-rocm643-gfx942.github/workflows/docker-publish.yml.docker/x86_gfx942/Dockerfile(HIP build,gfx942); thegfx90aDockerfile already existed.selfishbase tags are present on Docker Hub.On merge to
mainthis publisheshigherordermethods/self:latest-x86-rocm643-gfx90aand-gfx942(plus per-SHA tags), which downstream projects (e.g. self-uct) build against.Notes
gfx90abuild context is the existing, validated one;gfx942mirrors it with the CDNA3 offload arch.🤖 Generated with Claude Code