Conversation
Drop the v25 profile and promote its settings to the base build. Replace javax.servlet-api with jakarta.servlet-api 6.1.0 and add vaadin-dev dependency required for development mode in Vaadin 25.
Replace the removed custom Badge class with the native Vaadin Badge. Remove the @CssImport for badge.css since vaadin-badge manages its own styles via shadow DOM.
Badge styles are now managed by vaadin-badge's own shadow DOM.
Use 0.75em as the default icon size for base and Aura themes, and 1em for Lumo where the larger size fits the badge proportions.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (22)
💤 Files with no reviewable changes (3)
WalkthroughMigrates BadgeList add-on to Vaadin 25.1+ (v2.0.0) by replacing the custom Badge component with Vaadin's native Badge component. Removes custom Badge class and custom badge.css stylesheet, updates TypeScript component with ThemeDetectionMixin for theme awareness, enables the experimental badge component feature flag, upgrades Java target to version 21, and updates all demos to use the new Badge API. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |



Summary
Closes #34
Summary by CodeRabbit
New Features
Refactor
Chores