Feature/pronunciation#10
Open
wyj1026 wants to merge 5 commits intoFlowerowl:masterfrom
wyj1026:feature/pronunciation
Open
Feature/pronunciation#10wyj1026 wants to merge 5 commits intoFlowerowl:masterfrom wyj1026:feature/pronunciation
wyj1026 wants to merge 5 commits intoFlowerowl:masterfrom
wyj1026:feature/pronunciation
Conversation
Author
|
But the code is not clean enough, it might be a good idea to write a new method like |
Flowerowl
reviewed
Oct 8, 2017
ici/ici.py
Outdated
| def pronounce(node): | ||
| pros2play = [] | ||
| get_all_pros(node, pros2play) | ||
| subprocess.Popen("mpg123 -q "+" ".join(pros2play), shell=True) |
Owner
There was a problem hiding this comment.
mpg123 can play url，mpg123 -@ http://...mp3
Flowerowl
reviewed
Oct 8, 2017
ici/ici.py
Outdated
|
|
||
| def get_all_pros(node, pros2play): | ||
| if not node.hasChildNodes(): | ||
| if node.nodeType == node.TEXT_NODE and node.data != '\n': |
Owner
There was a problem hiding this comment.
you can just use regex to parse .mp3 urls
added 2 commits
October 9, 2017 23:47
Author
|
Thanks for your suggestions, anything more that I can improve? |
Repository owner
deleted a comment from
jimga150
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new feature which allows user to get the pronunciation of the word they search.
Usage:
ici -p word