Skip to content

#6233 Improve css validation#6234

Merged
sosnovsky merged 13 commits into
masterfrom
issue-6233-improve-css-validation
Jun 8, 2026
Merged

#6233 Improve css validation#6234
sosnovsky merged 13 commits into
masterfrom
issue-6233-improve-css-validation

Conversation

@martgil

@martgil martgil commented May 29, 2026

Copy link
Copy Markdown
Collaborator

This PR improves currently implemented css validation on rendered elements in pgp_block.

Closes #6233


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil martgil requested a review from sosnovsky as a code owner May 29, 2026 08:15
@martgil

This comment was marked as off-topic.

Comment thread extension/js/common/platform/xss.ts Outdated
@martgil martgil marked this pull request as draft May 29, 2026 10:30
@martgil martgil marked this pull request as ready for review June 2, 2026 09:01
@martgil martgil requested a review from sosnovsky June 2, 2026 09:02
@martgil

This comment was marked as outdated.

Comment thread extension/js/common/platform/xss.ts
@martgil martgil requested a review from sosnovsky June 3, 2026 11:18
@martgil

This comment was marked as outdated.

Comment thread extension/js/common/platform/xss.ts
Comment thread extension/js/common/platform/xss.ts Outdated
@martgil martgil marked this pull request as draft June 4, 2026 11:09
@martgil martgil marked this pull request as ready for review June 5, 2026 12:08
@martgil

martgil commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator Author

The failing test is not related to this PR but from a fragile test.

Comment thread extension/js/common/platform/xss.ts
@martgil martgil requested a review from sosnovsky June 7, 2026 09:31
@martgil

This comment was marked as off-topic.

Comment thread extension/js/common/platform/xss.ts
@martgil martgil requested a review from sosnovsky June 8, 2026 12:09

@sosnovsky sosnovsky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thanks for the fixes!

@sosnovsky sosnovsky merged commit 27afa36 into master Jun 8, 2026
12 checks passed
@sosnovsky sosnovsky deleted the issue-6233-improve-css-validation branch June 8, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve CSS validation

2 participants