Skip to content

Docs/simplify fellow weekly reports#2

Merged
Dumken1 merged 8 commits into
masterfrom
docs/simplify-fellow-weekly-reports
Jul 1, 2026
Merged

Docs/simplify fellow weekly reports#2
Dumken1 merged 8 commits into
masterfrom
docs/simplify-fellow-weekly-reports

Conversation

@Dumken1

@Dumken1 Dumken1 commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Pull Request Checklist

Branch

  • This branch was created from the latest master.
  • This work is scoped to one feature, research task, design task, documentation task, experiment, or fix.

Human Learning

  • I can explain what changed without relying only on AI output.
  • I added or updated a weekly report.
  • I added a human learning log if this work involved learning.
  • I added a paper note if a paper or technical source shaped the work.

Design And Research

  • I added a design outcome if the work changed architecture, flow, data model, interface, or evaluation approach.
  • I linked the relevant paper, article, official documentation, or technical source.
  • I explained the design decision and alternatives considered.

Verification

  • I ran the relevant tests, script, benchmark, or manual check.
  • I recorded evidence in the weekly report, benchmark results, screenshots, or notes.
  • I ran scripts/verify-contribution.ps1.

AI Use

  • I reviewed any AI-generated content before committing it.
  • I documented where AI helped if it influenced the work.
  • I made the final judgment as the human contributor.

Summary

What changed?

What did you learn?

What should the next contributor know?

Summary by CodeRabbit

  • Documentation

    • Updated contribution and branching guidance to use weekly integration branches and clearer report requirements.
    • Revised weekly report templates to a shorter, standardized format with topic, five-sentence summary, and public output link.
  • Chores

    • Added stronger contribution checks during repository validation, including branch naming and report presence.
    • Updated the contribution verification step to better match the new weekly workflow.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@Dumken1, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 39 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d11c2314-3110-4883-8961-1836a0c4311e

📥 Commits

Reviewing files that changed from the base of the PR and between e14aaa7 and a2f91fd.

📒 Files selected for processing (56)
  • .github/PULL_REQUEST_TEMPLATE.md
  • .github/workflows/repository-safety-check.yml
  • CONTRIBUTING.md
  • docs/branching-and-features.md
  • docs/documentation-guide.md
  • docs/project-structure-guide.md
  • docs/templates/weekly-report-template.md
  • reports/README.md
  • reports/month-01/week-02-local-storage.md
  • reports/month-01/week-03-local-ai-flow.md
  • reports/month-01/week-04-month-review.md
  • reports/month-02/week-01.md
  • reports/month-02/week-02.md
  • reports/month-02/week-03.md
  • reports/month-02/week-04.md
  • reports/month-03/week-01.md
  • reports/month-03/week-02.md
  • reports/month-03/week-03.md
  • reports/month-03/week-04.md
  • reports/month-04/week-01.md
  • reports/month-04/week-02.md
  • reports/month-04/week-03.md
  • reports/month-04/week-04.md
  • reports/month-05/week-01.md
  • reports/month-05/week-02.md
  • reports/month-05/week-03.md
  • reports/month-05/week-04.md
  • reports/month-06/week-01.md
  • reports/month-06/week-02.md
  • reports/month-06/week-03.md
  • reports/month-06/week-04.md
  • reports/month-07/week-01.md
  • reports/month-07/week-02.md
  • reports/month-07/week-03.md
  • reports/month-07/week-04.md
  • reports/month-08/week-01.md
  • reports/month-08/week-02.md
  • reports/month-08/week-03.md
  • reports/month-08/week-04.md
  • reports/month-09/week-01.md
  • reports/month-09/week-02.md
  • reports/month-09/week-03.md
  • reports/month-09/week-04.md
  • reports/month-10/week-01.md
  • reports/month-10/week-02.md
  • reports/month-10/week-03.md
  • reports/month-10/week-04.md
  • reports/month-11/week-01.md
  • reports/month-11/week-02.md
  • reports/month-11/week-03.md
  • reports/month-11/week-04.md
  • reports/month-12/week-01.md
  • reports/month-12/week-02.md
  • reports/month-12/week-03.md
  • reports/month-12/week-04.md
  • scripts/verify-contribution.ps1
📝 Walkthrough

Walkthrough

Introduces a weeks/month-XX-week-YY integration branch model replacing direct-to-master fellow workflows. The CI workflow is retargeted to enforce fellow branch naming, PR base-branch matching, and weekly report file presence. All 48 existing weekly report files and the report template are reformatted from individual planning sections to a shared two-fellow block format (topic, five sentences, public output link). Contributing and documentation files are updated throughout to match.

Changes

Weekly Branch Model and Fellow Contribution Format

Layer / File(s) Summary
CI workflow: branch naming, PR target, and report validation
.github/workflows/repository-safety-check.yml
Workflow renamed, re-triggered on fellows/** pushes and weeks/** PRs, with new steps enforcing branch-name regex, PR base-branch matching, required weekly report file in diff, and running verify-contribution.ps1.
verify-contribution.ps1: fellow and legacy format validation
scripts/verify-contribution.ps1
Validation logic replaced to accept either a new fellow-block regex pattern or legacy section phrases; reports matching neither format are recorded as failures.
Branching model, CONTRIBUTING, and architecture docs
CONTRIBUTING.md, docs/architecture.md, docs/branching-and-features.md, docs/baseline-start-guide.md, docs/releases/v0.1-week-01-baseline.md
Core rule, branch derivation examples, merge flow diagrams, and branch protection guidance updated throughout to reflect the weeks/month-XX-week-YY integration-branch model.
PR template, commit-verification, and guide docs
.github/PULL_REQUEST_TEMPLATE.md, docs/commit-verification.md, docs/documentation-guide.md, docs/project-structure-guide.md, README.md
PR checklist updated with new branch naming and script verification items; guide docs revised to describe shared weekly report, five-sentence requirement, and updated PR review criteria.
Weekly report template and reports/README
docs/templates/weekly-report-template.md, reports/README.md
Canonical template replaced with two-fellow block format; new reports/README.md documents the shared report location and fellow block editing rules.
48 weekly report files reformatted
reports/month-01/... through reports/month-12/...
Every weekly report across all 12 months has its prior planning/evidence sections replaced with the standardized two-fellow contribution block (topic, five sentences, public output link).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Possibly related PRs

  • Flow-Research/local-first-AI#1: Directly modifies the same .github/workflows/repository-safety-check.yml file, renaming the job and replacing its check steps with fellow branch and report validation logic that this PR extends.

Poem

🐇 A weekly branch for every hop,
Five sentences, then we stop.
fellows/ named just right,
The CI checks take flight —
One shared report per week on top! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the documentation-focused simplification of fellow weekly reports.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/simplify-fellow-weekly-reports

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Dumken1 Dumken1 self-assigned this Jun 30, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 6

🧹 Nitpick comments (1)
reports/README.md (1)

28-28: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Clarify concurrent editing guidance.

"Only edit your own block" works for sequential contributions but may confuse fellows if two contributors edit the same file in the same week before either merges. Consider adding guidance about resolving merge conflicts or coordinating on the weeks/* branch.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@reports/README.md` at line 28, The README guidance in the weekly fellows
section is too narrow for concurrent edits, so update the instructions near the
“Fellow 2/Fellow 3” note to also mention how to coordinate when multiple
contributors are editing the same file at once. Use the existing wording around
“Only edit your own block” and clarify that fellows should resolve merge
conflicts or coordinate on the relevant `weeks/*` branch before merging.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/repository-safety-check.yml:
- Around line 10-13: The repository-safety-check workflow is not triggered when
a PR’s base branch changes because `pull_request.edited` is missing from the
subscribed event types. Update the `pull_request` trigger in
`repository-safety-check.yml` to include `edited` alongside the existing events
so the base-branch validation runs again after retargeting. Keep the change
scoped to the workflow trigger section only.
- Around line 76-79: The weekly-report gate is comparing the two branch tips
instead of the actual PR delta, so update the check that uses BASE_SHA and
HEAD_SHA to diff against the merge-base of the PR branch and its target branch.
In the repository-safety-check workflow, keep the report_pattern matching logic
the same but change the git diff invocation so it only considers files
introduced by this PR, ensuring the grep test fails unless the PR itself touches
the expected reports/month-${month}/week-${week}*.md file.

In `@CONTRIBUTING.md`:
- Around line 51-60: The weekly documentation requirement is mismatched with
what validation actually checks: the CONTRIBUTING guidance in the Required
Weekly Documentation section says “exactly five sentences,” but the CI script
enforces five numbered list items. Update the wording to match the real rule if
the `reports/README.md`/verification logic expects numbered items, or otherwise
adjust the validator so it counts sentences instead of list entries; make the
chosen behavior consistent with the `reports/month-XX/week-YY.md` report format
and the fellow block instructions.

In `@docs/branching-and-features.md`:
- Around line 44-60: The weekly report requirement in the branching guide
conflicts with the actual validation in verify-contribution.ps1: the docs say to
write exactly five sentences, but the script checks for five numbered list
items. Update the documentation text in branching-and-features.md to match the
real check, or adjust verify-contribution.ps1 if the intended rule is truly
sentence-based, and keep the wording consistent around the weekly report and
fellow block requirements so contributors can satisfy the same rule that CI
enforces.

In `@reports/month-06/week-04.md`:
- Around line 3-25: The weekly report template replacement in the report content
has overwritten existing historical project data with placeholders. Update the
reformatting logic for the report blocks so it preserves or migrates the
original weekly privacy review outline content instead of resetting it, using
the existing report structure as the source of truth. Check the report
generation/editing flow that produced the Fellow sections and ensure any
refactor keeps the goal, research, design outcome, build progress, evidence,
blockers, and next step content intact, or explicitly restore it from git
history if it was lost.

In `@scripts/verify-contribution.ps1`:
- Around line 51-66: The weekly report check in verify-contribution.ps1 is too
permissive because it only matches scattered tokens anywhere in the text;
tighten the Fellow format validation so a report must match one complete,
ordered block rather than unrelated headings and numbered lines. Update the
logic around usesFellowFormat to validate the structure of the report as a
single contiguous section anchored to the expected Fellow heading and its
required subsections, while keeping the legacy-format fallback separate.

---

Nitpick comments:
In `@reports/README.md`:
- Line 28: The README guidance in the weekly fellows section is too narrow for
concurrent edits, so update the instructions near the “Fellow 2/Fellow 3” note
to also mention how to coordinate when multiple contributors are editing the
same file at once. Use the existing wording around “Only edit your own block”
and clarify that fellows should resolve merge conflicts or coordinate on the
relevant `weeks/*` branch before merging.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 24385a1f-5cec-40c2-a2f5-1f22db05f202

📥 Commits

Reviewing files that changed from the base of the PR and between 512fb55 and e14aaa7.

📒 Files selected for processing (61)
  • .github/PULL_REQUEST_TEMPLATE.md
  • .github/workflows/repository-safety-check.yml
  • CONTRIBUTING.md
  • README.md
  • docs/architecture.md
  • docs/baseline-start-guide.md
  • docs/branching-and-features.md
  • docs/commit-verification.md
  • docs/documentation-guide.md
  • docs/project-structure-guide.md
  • docs/releases/v0.1-week-01-baseline.md
  • docs/templates/weekly-report-template.md
  • reports/README.md
  • reports/month-01/week-02-local-storage.md
  • reports/month-01/week-03-local-ai-flow.md
  • reports/month-01/week-04-month-review.md
  • reports/month-02/week-01.md
  • reports/month-02/week-02.md
  • reports/month-02/week-03.md
  • reports/month-02/week-04.md
  • reports/month-03/week-01.md
  • reports/month-03/week-02.md
  • reports/month-03/week-03.md
  • reports/month-03/week-04.md
  • reports/month-04/week-01.md
  • reports/month-04/week-02.md
  • reports/month-04/week-03.md
  • reports/month-04/week-04.md
  • reports/month-05/week-01.md
  • reports/month-05/week-02.md
  • reports/month-05/week-03.md
  • reports/month-05/week-04.md
  • reports/month-06/week-01.md
  • reports/month-06/week-02.md
  • reports/month-06/week-03.md
  • reports/month-06/week-04.md
  • reports/month-07/week-01.md
  • reports/month-07/week-02.md
  • reports/month-07/week-03.md
  • reports/month-07/week-04.md
  • reports/month-08/week-01.md
  • reports/month-08/week-02.md
  • reports/month-08/week-03.md
  • reports/month-08/week-04.md
  • reports/month-09/week-01.md
  • reports/month-09/week-02.md
  • reports/month-09/week-03.md
  • reports/month-09/week-04.md
  • reports/month-10/week-01.md
  • reports/month-10/week-02.md
  • reports/month-10/week-03.md
  • reports/month-10/week-04.md
  • reports/month-11/week-01.md
  • reports/month-11/week-02.md
  • reports/month-11/week-03.md
  • reports/month-11/week-04.md
  • reports/month-12/week-01.md
  • reports/month-12/week-02.md
  • reports/month-12/week-03.md
  • reports/month-12/week-04.md
  • scripts/verify-contribution.ps1

Comment thread .github/workflows/repository-safety-check.yml Outdated
Comment thread .github/workflows/repository-safety-check.yml Outdated
Comment thread CONTRIBUTING.md
Comment thread docs/branching-and-features.md Outdated
Comment thread reports/month-06/week-04.md
Comment thread scripts/verify-contribution.ps1 Outdated
Dumken1 and others added 3 commits July 1, 2026 05:59
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@Dumken1 Dumken1 merged commit ef797a2 into master Jul 1, 2026
1 check passed
@Dumken1 Dumken1 deleted the docs/simplify-fellow-weekly-reports branch July 6, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant