Skip to content

Add missing jarvis-cli dev dependencies#43

Open
Techris93 wants to merge 2 commits into
Flow-Research:mainfrom
Techris93:codex/fix-jarvis-cli-uv-dev-deps
Open

Add missing jarvis-cli dev dependencies#43
Techris93 wants to merge 2 commits into
Flow-Research:mainfrom
Techris93:codex/fix-jarvis-cli-uv-dev-deps

Conversation

@Techris93

@Techris93 Techris93 commented May 20, 2026

Copy link
Copy Markdown

Summary

  • Add the dev dependencies needed by the existing jarvis-cli test/lint configuration
  • Update uv.lock for the new dev dependency group entries
  • Remove two unused imports surfaced by Ruff

Verification

  • uv sync --dev --frozen
  • uv run ruff check src/jarvis/config tests/unit/config
  • uv run pytest -q tests/unit/config tests/journal/test_capture.py

Summary by CodeRabbit

  • Chores
    • Added several development tools to the project’s dev environment, including type checking, testing, coverage, and linting utilities.
    • No user-facing behavior or application logic was changed.

@Konan69

Konan69 commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 6, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Jun 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4fbe1dfc-0eb7-465e-b6a9-e8bb50cdd0d8

📥 Commits

Reviewing files that changed from the base of the PR and between af0d719 and aa88352.

⛔ Files ignored due to path filters (1)
  • jarvis-cli/uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • jarvis-cli/pyproject.toml

📝 Walkthrough

Walkthrough

The pyproject.toml file for jarvis-cli is updated to add five development tooling packages—mypy, pytest, pytest-asyncio, pytest-cov, and ruff—to the existing dev dependency group. No application code was modified.

Changes

Configuration Updates

Layer / File(s) Summary
Development tooling dependencies
jarvis-cli/pyproject.toml
Adds mypy, pytest, pytest-asyncio, pytest-cov, and ruff to the [dependency-groups].dev list.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding missing jarvis-cli development dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…uv-dev-deps

# Conflicts:
#	jarvis-cli/src/jarvis/config/loader.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants