Port PKAs and Crushers for Lavaland (WIP)

[Dunrab]

About the PR

Additional pkas and crusher varitants to be used by salvage.

todo:

• add a link to the goob pr for pkas
• add a link to the ADT pr that added the crusher variants
• add them to research so they can be researched
• maybe add to them to the vendor but make them more expensive than a standard PKA since these have more utility.
• probably will just remove a bunch of these un-used states, since we are using delta-vs upgrade system instead of the goob one

Why / Balance

Cool weapons.

Technical details

This hurt my head but here we are. WIP, going to let tests run then write up actual details.

Media

Click to show

Requirements

• I have tested all added content and changes.
• I have added media to this PR or it does not require an ingame showcase.

Licensing:

• I confirm that I am the creator of the content in this PR, and allow licensing it under the following license(s), or that the original author has given me permission to do so:
  • AGPL (https://github.com/Floof-Station/Panta-Rhei/blob/master/LICENSE-AGPLv3.txt)
  • MIT (https://github.com/Floof-Station/Panta-Rhei/blob/master/LICENSE-MIT.txt)

Breaking changes

Changelog

🆑

• add: New PKA and Crusher variants.

[github-actions]

RSI Diff Bot; head commit 019e7a0 merging into 3a08cff
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_Lavaland/Objects/Weapons/Guns/Basic/kinetic_repeater.rsi

State	Old	New	Status
bayonet			Removed

Resources/Textures/_Lavaland/Objects/Specific/loot.rsi

State	Old	New	Status
crystal			Added
cursed_heart			Added

Resources/Textures/_Lavaland/Objects/Weapons/Crushers/crusher_halberd-inhands.rsi

State	Old	New	Status
inhand-left			Added
inhand-right			Added
wielded-inhand-left			Added
wielded-inhand-right			Added

Resources/Textures/_Lavaland/Objects/Weapons/Crushers/crusher_halberd.rsi

State	Old	New	Status
equipped-BACKPACK			Added
equipped-SUITSTORAGE			Added
flashlight			Added
icon-lit			Added
icon-uncharged			Added
icon			Added
upgrade-handle-lightweight			Added
upgrade-handle-range			Added
upgrade-handle-weights			Added
upgrade-ice-frost			Added
upgrade-lava-aspect			Added
upgrade-marker			Added
upgrade-rude-buster			Added
upgrade-sharpness			Added

Resources/Textures/_Lavaland/Objects/Weapons/Crushers/crusher_hammer-inhands.rsi

State	Old	New	Status
inhand-left			Added
inhand-right			Added
wielded-inhand-left			Added
wielded-inhand-right			Added

Resources/Textures/_Lavaland/Objects/Weapons/Crushers/crusher_hammer.rsi

State	Old	New	Status
equipped-BACKPACK			Added
equipped-SUITSTORAGE			Added
flashlight			Added
icon-lit			Added
icon-uncharged			Added
icon			Added
upgrade-handle-lightweight			Added
upgrade-handle-range			Added
upgrade-handle-weights			Added
upgrade-ice-frost			Added
upgrade-lava-aspect			Added
upgrade-marker			Added
upgrade-rude-buster			Added
upgrade-sharpness			Added

Resources/Textures/_Lavaland/Objects/Weapons/Guns/Basic/kinetic_pistol.rsi

State	Old	New	Status
animation-icon			Added
equipped-BELT			Added
equipped-SUITSTORAGE			Added
icon			Added
inhand-left			Added
inhand-right			Added
upgrade-space			Added

Resources/Textures/_Lavaland/Objects/Weapons/Guns/Basic/kinetic_railgun.rsi

State	Old	New	Status
animation-icon			Added
bayonet			Added
equipped-BELT			Added
equipped-SUITSTORAGE			Added
icon			Added
inhand-left			Added
inhand-right			Added
wielded-inhand-left			Added
wielded-inhand-right			Added

Resources/Textures/_Lavaland/Objects/Weapons/Guns/Basic/kinetic_shotgun.rsi

State	Old	New	Status
animation-icon			Added
equipped-BELT			Added
equipped-SUITSTORAGE			Added
icon			Added
inhand-left			Added
inhand-right			Added
upgrade-space			Added
wielded-inhand-left			Added
wielded-inhand-right			Added

Resources/Textures/_Lavaland/Objects/Weapons/Secondary/kinetic_claws-inhands.rsi

State	Old	New	Status
equipped-HAND			Added
inhand-left			Added
inhand-right			Added
wielded-inhand-left			Added
wielded-inhand-right			Added

Resources/Textures/_Lavaland/Objects/Weapons/Secondary/kinetic_claws.rsi

State	Old	New	Status
icon-lit			Added
icon-uncharged			Added
icon			Added

Resources/Textures/_Lavaland/Objects/Weapons/Secondary/kinetic_machete-inhands.rsi

State	Old	New	Status
inhand-left			Added
inhand-right			Added

Edit: diff updated after 019e7a0

[SyaoranFox]

As a heads up: be wary of the extra combat abilities that Goob has that are associated with these weapons. It was the primary reason I didn't port them over in the first run.

[Dunrab]

As a heads up: be wary of the extra combat abilities that Goob has that are associated with these weapons. It was the primary reason I didn't port them over in the first run.

I plan to remove a lot of the extra combat abilities from these weapons, the crushers for an example are just other crusher variants with different damage types and utility, i'm not going to make them upgradeable. The PKAs are upgradable but we will want to tweak damage and possibly the amount of upgrade capacity

[Dunrab]

putting needs discussion on this since we will need to talk about how the hell want to balance these