fix(settings): picking a theme switches Material You off so the pick applies#100
Merged
Merged
Conversation
…applies The theme dropdowns persisted the choice but Material You (on by default) kept overriding it, so on most devices picking a theme appeared to do nothing; the only clue was the hint sentence below the dropdowns. Choosing a named theme is an explicit statement of intent, so the pick now switches dynamic color off in the same edit and takes effect immediately. Re-enabling Material You afterwards still works and keeps the slot choice. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The theme dropdowns worked mechanically (the choice persisted and applied with Material You off), but Material You is on by default and overrides the named themes, so on most devices picking a theme appeared to do nothing. The only clue was the hint sentence below the second dropdown. Reported as "theme selection doesn't do anything".
Picking a named theme is an explicit statement of intent to use it, so the pick now switches dynamic color off in the same edit and takes effect immediately. Re-enabling Material You afterwards is respected and keeps the slot choice. The hint text still reads correctly for the remaining case (toggling Material You on after a pick), and no translated strings change.
Verification
Checklist
fix/branch offmain./gradlew ktlintCheck lint test assembleDebugis green locallyopenspec validate <name> --strict) and tasks are checked off — n/a (small UX fix)🤖 Generated with Claude Code