Skip to content

fix(gui): open the About dialog wide enough for its content#99

Merged
ErikChevalier merged 1 commit into
mainfrom
fix/about-dialog-width
Jul 3, 2026
Merged

fix(gui): open the About dialog wide enough for its content#99
ErikChevalier merged 1 commit into
mainfrom
fix/about-dialog-width

Conversation

@ErikChevalier

Copy link
Copy Markdown
Contributor

Problem

The About popup could open too narrow and show a horizontal scrollbar. Its opening width was fixed at 640px, but the width the content needs tracks the app font size and the active language. Reproduced offscreen: even at the default 12pt the content minimum is 626px while the fixed size leaves a 602px viewport (scrollbar already visible); at 16pt the content needs 765px and at 20pt 933px.

Fix

Derive the opening width from the scroll content's minimum width plus the scroll-area chrome (vertical scrollbar, frame, layout margins), clamped to the available screen, keeping 640x720 as the floor. On a normal desktop the dialog now opens with no horizontal scrollbar at any text-size setting; on a genuinely too-small screen it clamps to the screen and scrolls, which is the best available behavior.

The changelog entry rides in the still-unpublished 26.07.01 section so the fix ships with today's release (rc.2 to follow).

Verification

  • New regression test at 20pt with a mocked 1920x1080 screen (the offscreen test platform's 800x600 fake screen would otherwise mask the width derivation); asserts the viewport fits the content minimum and no horizontal scrollbar is visible.
  • Verified at 12/16/20/24pt offscreen: viewport >= content minimum, no scrollbar at every size.
  • Full suite 764 passed, ruff and mypy strict green.

🤖 Generated with Claude Code

The dialog opened at a fixed 640px, but the width its content needs
tracks the app font size and the active language: at larger text sizes
(and even at the default 12pt, where the content minimum is 626px but
the fixed size left only a 602px viewport) the widest rows overflowed
and the scroll area showed a horizontal scrollbar over a short static
page. Derive the opening width from the content's minimum plus the
scroll-area chrome, clamped to the available screen, so the dialog
always opens showing its full width.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@ErikChevalier ErikChevalier merged commit 593729c into main Jul 3, 2026
1 check passed
@ErikChevalier ErikChevalier deleted the fix/about-dialog-width branch July 3, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant