Skip to content

feat(kernel): added PTY subsystem, proc_set_handle API, and reusable line discipline#66

Merged
FlareCoding merged 1 commit intostellux-3.0-prototypingfrom
pr/pty-impl
Mar 4, 2026
Merged

feat(kernel): added PTY subsystem, proc_set_handle API, and reusable line discipline#66
FlareCoding merged 1 commit intostellux-3.0-prototypingfrom
pr/pty-impl

Conversation

@FlareCoding
Copy link
Owner

@FlareCoding FlareCoding commented Mar 4, 2026

Note

Medium Risk
Touches kernel resource/handle management and adds new syscalls and terminal I/O paths; bugs could cause handle leaks, incorrect rights propagation, or PTY/console read-write/close edge cases.

Overview
Adds a new PTY resource type and subsystem, including pty_create syscall to allocate a master/slave pair backed by ring buffers and a per-PTY line discipline (with cooked/raw mode and optional echo).

Extends process management with proc_set_handle, enabling callers to replace a specific handle slot in a CREATED child before proc_start, supported by new handle-table helpers (get_handle_object can return rights; install_handle_at replaces an existing slot safely).

Refactors console input handling into a reusable terminal/line_discipline module and updates the console terminal to use it; adds kernel PTY unit tests and a userland ptytest app plus libstlx wrappers and syscall number definitions.

Written by Cursor Bugbot for commit 9614e1f. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@FlareCoding FlareCoding merged commit 899e4fe into stellux-3.0-prototyping Mar 4, 2026
15 checks passed
@FlareCoding FlareCoding deleted the pr/pty-impl branch March 4, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant