Skip to content

Conversation

@kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jan 6, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Closes #6474
Closes #6473

  • Feature-specific segments will now only show the feature that is relevant, it will open the feature in a new tab since removing segment overrides from here would push it into a weird state
  • Segment overrides that appear to the be the same as environment defaults will now highlight
image image

kyle-ssg and others added 3 commits January 6, 2026 12:39
- Hide Features tab and show single Feature tab for feature-specific segments
- Filter feature list to show only associated feature when segment.feature exists
- Add ConnectedFeatureOverrideRow component to handle feature data fetching
- Open feature in new tab instead of modal for feature-specific segments
- Show "This feature is being overridden for this segment" message when override exists but matches environment defaults
- Update tab labels and page titles to use singular "Feature" for feature-specific segments
- Reorganize segment form to move trait type conversion info near rules section
- Improve conditional rendering logic to avoid nested ternaries

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@kyle-ssg kyle-ssg requested a review from a team as a code owner January 6, 2026 15:35
@kyle-ssg kyle-ssg requested review from Zaimwa9 and removed request for a team January 6, 2026 15:35
@vercel
Copy link

vercel bot commented Jan 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Jan 6, 2026 3:35pm
flagsmith-frontend-staging Ready Ready Preview, Comment Jan 6, 2026 3:35pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Ignored Ignored Jan 6, 2026 3:35pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jan 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6478 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6478 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6478 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6478 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6478 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6478 Finished ✅ Results

@kyle-ssg kyle-ssg changed the title Feat/improve segment feature association feat: improve segment feature association Jan 6, 2026
Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a NIT that I leave up to you

@Zaimwa9 Zaimwa9 merged commit 58015b1 into main Jan 7, 2026
26 of 31 checks passed
@Zaimwa9 Zaimwa9 deleted the feat/improve-segment-feature-association branch January 7, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overrides should highlight features even if values are the same Associated features show even for feature-specific segments

3 participants