Skip to content

Conversation

@emyller
Copy link
Contributor

@emyller emyller commented Dec 30, 2025

Deprecated LaunchDarkly flags are imported as archived flags with a "Deprecated" tag to reduce confusion during the import process.

Changes

  • Archive deprecated flags on import (in addition to archived flags)
  • Add "Deprecated" tag to deprecated flags to distinguish them from flags archived in LaunchDarkly
  • Clarify that archived flags continue to evaluate normally for SDKs in both platforms
  • Improve UX around importing by adding user feedback to the UI. Before, the code polled for import status and just refreshed the page back to "Import" with no user feedback.
image

Closes #5642

Review effort: 2/5

Warning

My frontend mastery is very out of date. UI changes in this patch rely on interactions with AI.

@emyller emyller requested review from a team as code owners December 30, 2025 20:50
@emyller emyller requested review from adamvialpando and khvn26 and removed request for a team December 30, 2025 20:50
@vercel
Copy link

vercel bot commented Dec 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Review Updated (UTC)
docs Ignored Ignored Preview Jan 7, 2026 6:43pm
flagsmith-frontend-preview Ignored Ignored Preview Jan 7, 2026 6:43pm
flagsmith-frontend-staging Ignored Ignored Preview Jan 7, 2026 6:43pm

@emyller emyller self-assigned this Dec 30, 2025
@github-actions github-actions bot added api Issue related to the REST API docs Documentation updates fix and removed docs Documentation updates labels Dec 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6447 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6447 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6447 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6447 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6447 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6447 Finished ✅ Results

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.07%. Comparing base (38ac162) to head (fc4076f).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6447   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files        1294     1294           
  Lines       46535    46545   +10     
=======================================
+ Hits        45637    45647   +10     
  Misses        898      898           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emyller emyller force-pushed the fix/ld-importer/archive-deprecated-flags branch from 601ab7f to fdcec4b Compare December 31, 2025 03:23
@github-actions github-actions bot added the docs Documentation updates label Dec 31, 2025
@github-actions github-actions bot added fix and removed fix docs Documentation updates labels Dec 31, 2025
khvn26
khvn26 previously approved these changes Jan 1, 2026
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emyller emyller marked this pull request as draft January 3, 2026 04:46
@emyller emyller force-pushed the fix/ld-importer/archive-deprecated-flags branch from fdcec4b to cff70ec Compare January 5, 2026 16:46
@emyller emyller requested a review from khvn26 January 5, 2026 16:46
@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard docs Documentation updates labels Jan 5, 2026
…ve-deprecated-flags

# Conflicts:
#	frontend/web/components/pages/FeaturesPage.js
@emyller emyller marked this pull request as ready for review January 5, 2026 16:52
@emyller emyller requested a review from a team as a code owner January 5, 2026 16:52
@emyller emyller requested review from talissoncosta and removed request for a team January 5, 2026 16:52
@cursor
Copy link

cursor bot commented Jan 5, 2026

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on January 10.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

task_processor is now part of flagsmith-common and doesn't need to be
cloned separately. This has been broken since August 2024 when the
clone was added without the corresponding pyproject.toml entry.
@github-actions github-actions bot added the docs Documentation updates label Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API docs Documentation updates fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LD Importer: Tag deprecated flags as archived when importing into Flagsmith

4 participants