feat(frontend): add Jest unit testing infrastructure #6432
+10,463
−6,510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
github-actions
bot
added
the
front-end
talissoncosta
force-pushed
the
feat/add-jest-unit-tests
branch
from
ef6d2cb to
0635372
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6432 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 1294 1294
Lines 46535 46537 +2
=======================================
+ Hits 45637 45639 +2
Misses 898 898 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Zaimwa9
reviewed
Dec 19, 2025
talissoncosta
changed the title
Contributor
Docker builds report
|
github-actions
bot
added
feature
github-actions
bot
added
feature
Zaimwa9
reviewed
Dec 31, 2025
Contributor
Zaimwa9
left a comment
Zaimwa9
left a comment
There was a problem hiding this comment.
Just adding a prop and to the deploy to production pipeline and should be good to go. Thanks for the initiative!
Base automatically changed from
revert-6428-revert-6361-refactor/migrate-critical-components-featurespagejs-2
to
main
January 5, 2026 14:20
The new RTK-based toggle hook was missing the `use_v2_feature_versioning` check that exists in the legacy Flux store. This caused errors when toggling features in versioned environments. - Add versioning check to useToggleFeatureWithToast hook - Use createAndSetFeatureVersion mutation for versioned environments - Use updateFeatureState mutation for non-versioned environments - Pass environment object from FeaturesPage to get versioning setting 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The getFeatureStateCrud function used `!v.feature_segment` to find the environment default state, but the caller filtered with `!v.feature_segment?.segment`. When the API returns feature_segment as an object with segment: null, these filters produced different results, causing "Feature contains no changes" error. Also improved error message extraction in useToggleFeatureWithToast. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…vironments When FeaturesPage uses RTK Query, the legacy FeatureListStore.model is never initialized. This causes the CreateFlag modal's save flow to fail in versioned environments because the store operations depend on model being populated. Added a useEffect to call AppActions.getFeatures on mount, which initializes store.model so the modal's legacy save flow works correctly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The Django API's EnvironmentViewSet uses lookup_field="api_key", so the
/environments/{lookup}/featurestates/ endpoint expects the environment's
API key string, not the numeric ID.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The versioned toggle was failing with 404 because getFeatureStates
expects ?environment={numeric_id} but was receiving the api_key string.
- Add environmentApiKey (optional) and environmentId (number) to request type
- Pass both IDs from useToggleFeatureWithToast (which has the full Environment object)
- Skip optimistic update for legacy store flow (doesn't pass environmentApiKey)
- Fix getVersionFeatureState type to expect number instead of string
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add Jest with ts-jest for TypeScript support - Add jest.config.js with path aliases matching tsconfig - Add npm scripts: test:unit, test:unit:watch, test:unit:coverage - Migrate format.js to format.ts for better Jest compatibility - Add unit tests for featureFilterParams utility Tests cover: - buildUrlParams: is_archived always explicitly set (never undefined) - buildApiFilterParams: is_archived always included in API params - getFiltersFromParams: URL param parsing - hasActiveFilters: filter state detection This prevents regression of the archived features bug where is_archived was undefined instead of explicitly 'false'. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Runs Jest unit tests on PRs that modify frontend/ files. Runs on all PRs including drafts (tests are fast and cheap). Lint and typecheck can be added later once those are cleaned up. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add 45 unit tests for Format utility pure functions - Remove unnecessary .toString() in countdown: parseInt(x.toString()) → Math.floor(x) - Remove unnecessary .toString() in shortenNumber: +parseFloat(x.toString()).toFixed(1) → +x.toFixed(1) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add explicit moment import to fix TypeScript UMD global error - Simplify money() to consistently return defaultValue for null/undefined/0 - Update tests to reflect new behavior 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add clearMocks: true to Jest config for automatic mock cleanup - Add unit tests job to frontend-deploy-production.yml workflow - Update package-lock.json after rebase Addresses review comments from @Zaimwa9 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
talissoncosta
force-pushed
the
feat/add-jest-unit-tests
branch
from
0876e33 to
0947abc
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
github-actions
bot
added
feature
Reset FeaturesPage.tsx and useToggleFeatureWithToast.ts to main since those changes belong to the FeaturesPage migration PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
github-actions
bot
added
feature
Address security warning from github-advanced-security bot by adding explicit permissions block with minimal `contents: read` scope. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
github-actions
bot
added
feature
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
github-actions
bot
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Jest unit testing infrastructure to the frontend codebase to enable fast, isolated unit tests alongside the existing TestCafe E2E tests.
Closes #6442
Changes
Jest Configuration
ts-jestpreset for TypeScript supportcommon/,components/,project/)common/andweb/directoriesCI/CD Integration
frontend-pull-request.yml)Initial Test Coverage
featureFilterParamsutilitybuildUrlParams,buildApiFilterParams,getFiltersFromParams,hasActiveFiltersDependencies Added
jest,ts-jest,@types/jestHow did you test this code?
cd frontend npm run test:unitAll 27 tests pass.
Checklist
docs/if required so people know about the feature!