fix: prevent IDOR vulnerability in environment update endpoint #6384
+59
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Contributor
Docker builds report
|
api/environments/serializers.py
Outdated
Comment on lines
133
to
137
| def __init__(self, *args: Any, **kwargs: Any) -> None: | ||
| super().__init__(*args, **kwargs) # type: ignore[no-untyped-call] | ||
| # Prevent IDOR: project cannot be changed after creation | ||
| if self.instance is not None: | ||
| self.fields["project"].read_only = True |
Contributor
There was a problem hiding this comment.
A neater option here is probably just to separate the Create and Update serializers?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6384 +/- ##
==========================================
+ Coverage 98.02% 98.07% +0.04%
==========================================
Files 1282 1292 +10
Lines 45498 46526 +1028
==========================================
+ Hits 44600 45629 +1029
+ Misses 898 897 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gagantrivedi
force-pushed
the
fix/idor-environment-project-validation
branch
from
90b1762 to
cd0e004
Compare
Make the `project` field read-only during environment updates to prevent attackers from moving an environment to a different project they don't own. The vulnerability allowed an attacker with access to their own environment to modify the `project` field in the PUT request body, effectively moving their environment into a victim's project. Fix: Override __init__ in CreateUpdateEnvironmentSerializer to set project field as read-only when instance exists (update operation).
gagantrivedi
force-pushed
the
fix/idor-environment-project-validation
branch
from
cd0e004 to
d29b554
Compare
matthewelwell
previously approved these changes
Dec 17, 2025
Contributor
matthewelwell
left a comment
matthewelwell
left a comment
There was a problem hiding this comment.
Approving with a couple of minor comments.
api/environments/serializers.py
Outdated
Comment on lines
137
to
141
| # handle `project` not being part of the data | ||
| # When request comes from yasg2(as part of schema generation) | ||
| project_id = view.request.data.get("project") | ||
| if not project_id: | ||
| return None |
Contributor
There was a problem hiding this comment.
Another (perhaps more descriptive) option here would be:
Suggested change
| # handle `project` not being part of the data | |
| # When request comes from yasg2(as part of schema generation) | |
| project_id = view.request.data.get("project") | |
| if not project_id: | |
| return None | |
| if getattr(self.request, "swagger_fake_view", False): | |
| return Subscription.objects.none() | |
| project_id = self.request.data["project"] |
api/environments/serializers.py
Outdated
Comment on lines
157
to
158
| if self.instance is None: | ||
| return None |
Contributor
There was a problem hiding this comment.
This should never be the case, right? Is this to handle swagger again? If so, I prefer the explicit approach I suggested above.
Address PR review comments by using explicit swagger_fake_view attribute check instead of implicit project_id presence check.
gagantrivedi
force-pushed
the
fix/idor-environment-project-validation
branch
from
733c2ae to
28e10e7
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on January 10
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Make the
projectfield read-only during environment updates to prevent moving an environment to a different projectThe vulnerability allowed an attacker with access to their own environment to modify the
projectfield in the PUT request body, effectively moving their environment into a victim's project.Fix: Override init in CreateUpdateEnvironmentSerializer to set project field as read-only when instance exists (update operation).
How did you test this code?
Adds unit test