-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Add DynamoDB document schemas #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (98.31%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## ci/uv-renovate #137 +/- ##
==================================================
+ Coverage 94.72% 95.32% +0.60%
==================================================
Files 76 79 +3
Lines 2444 2673 +229
==================================================
+ Hits 2315 2548 +233
+ Misses 129 125 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ts relationship with Environment.id
…r roles in flag evaluations
…e understanding of their roles in multivariate bucketing
…its indexing status
Zaimwa9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with a NIT wording, i leave it up to you. Otherwise I consider @gagantrivedi' comments to have been resolved
Co-authored-by: Zaimwa9 <wadii.zaim@gmail.com>
Gagan is out today; all of his threads were addressed and double-checked by a peer.
Contributes to #128.
In this PR, we add Python stdlib-based DynamoDB document schemas for Flagsmith's Edge API data model.
The goals are to:
Initially, I was hesitant to add validation code to this package. I'm considering to add it now, however, in a subsequent PR, so it can be consumed in environments where Pydantic is still possible to use.
I've added a bunch of TODOs that I expect to resolve prior to merging the current PR, and highlighted them by starting relevant review threads.