Add shadows enumeration to VEML 3.1 effects-settings for global light control#90
Draft
Copilot wants to merge 7 commits into
Draft
Add shadows enumeration to VEML 3.1 effects-settings for global light control#90Copilot wants to merge 7 commits into
Copilot wants to merge 7 commits into
Conversation
Co-authored-by: dyfios <16926525+dyfios@users.noreply.github.com>
Co-authored-by: dyfios <16926525+dyfios@users.noreply.github.com>
Co-authored-by: dyfios <16926525+dyfios@users.noreply.github.com>
Co-authored-by: dyfios <16926525+dyfios@users.noreply.github.com>
Co-authored-by: dyfios <16926525+dyfios@users.noreply.github.com>
Co-authored-by: dyfios <16926525+dyfios@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add shadows enumeration field to effects-settings in VEML
Add shadows enumeration to VEML 3.1 effects-settings for global light control
Jan 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VEML schema lacked standardized global shadow settings. This adds a
shadowsenumeration field toeffects-settingsin VEML 3.1 enabling world-wide light shadow control.Schema Changes
http://www.fivesqd.com/schemas/veml/3.1off,on,preserveeffectssettingswith proper XML serializationImplementation
VEMLHandler.cs:
ProcessShadowsSetting()iterates light entities and applies UnityLightShadowssettingoff→LightShadows.Noneon→LightShadows.Softpreserve→ no change (default)VEMLUtilities.cs: V3.0→V3.1 conversion via XML serialization with namespace replacement
Schema migration: All versions 1.0-3.0 auto-upgrade through conversion chain
Testing
External Dependencies
XSD schema in
@Five-Squared-Interactive/VEMLrepository requires separate update.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.