-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(ci): use workflow_dispatch for polish release notes #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The claude-code-action doesn't support the `release` event type. Switch to workflow_dispatch which is supported, and have release-prepare trigger it after publishing.
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughThe pull request modifies GitHub Actions workflows to integrate the Claude-based release notes polishing feature. The Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review CompleteYour review story is ready! Comment !reviewfast on this PR to re-generate the story. |
Greptile SummaryFixes the polish release notes workflow by switching from unsupported
The workflow chain now works: push to main → changesets publishes → triggers polish workflow → Claude polishes release notes. Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User as Developer
participant Main as main branch
participant RP as release-prepare.yml
participant CS as Changesets Action
participant NPM as npm Registry
participant GH as GitHub Releases
participant PR as polish-release-notes.yml
participant Claude as Claude Code Action
User->>Main: Push to main
Main->>RP: Trigger workflow
RP->>CS: Run changesets/action
CS->>CS: Check for changesets
alt Version PR exists
CS->>GH: Create/Update Version PR
else Version PR merged
CS->>NPM: Publish packages
CS->>GH: Create release with tag
CS-->>RP: outputs.published = 'true'
RP->>GH: gh release list (get latest tag)
RP->>PR: gh workflow run polish-release-notes.yml
PR->>GH: Fetch release notes
PR->>Claude: Transform with claude-code-action
Claude->>PR: Return polished notes + title
PR->>GH: Update release with polished content
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 1 comment
| # Get the latest release tag | ||
| TAG=$(gh release list --limit 1 --json tagName -q '.[0].tagName') | ||
| echo "Triggering polish workflow for $TAG" | ||
| gh workflow run polish-release-notes.yml -f tag_name="$TAG" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: verify that gh release list --limit 1 returns the most recently published release - the command assumes chronological ordering (newest first)
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/release-prepare.yml
Line: 71:71
Comment:
**style:** verify that `gh release list --limit 1` returns the most recently published release - the command assumes chronological ordering (newest first)
How can I resolve this? If you propose a fix, please make it concise.* fix(ci): use workflow_dispatch for polish release notes The claude-code-action doesn't support the `release` event type. Switch to workflow_dispatch which is supported, and have release-prepare trigger it after publishing. * fix: get tag from package.json instead of gh release list
Summary
claude-code-actiondoesn't supportreleaseevents, but does supportworkflow_dispatchrelease-preparetrigger the polish workflow after publishing viagh workflow runChanges
polish-release-notes.yml:release: publishedtriggerworkflow_dispatch(which is supported)release-prepare.yml:Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.