Repo improvements: CI feature coverage, MSRV, release hardening, docs, and CLI refactor#28
Closed
Finesssee wants to merge 5 commits into
Closed
Repo improvements: CI feature coverage, MSRV, release hardening, docs, and CLI refactor#28Finesssee wants to merge 5 commits into
Finesssee wants to merge 5 commits into
Conversation
…endabot Co-authored-by: NessZerra <Finesssee@users.noreply.github.com>
Co-authored-by: NessZerra <Finesssee@users.noreply.github.com>
Co-authored-by: NessZerra <Finesssee@users.noreply.github.com>
Co-authored-by: NessZerra <Finesssee@users.noreply.github.com>
Co-authored-by: NessZerra <Finesssee@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A batch of maintainability and correctness improvements identified during a repo review. Each logical change is a separate commit.
CI / tooling
--all-features(covers thesecure-storagekeyring path) in addition to default features.cargoinvocations in CI use--lockedto catchCargo.lockdrift.--all-features).rust-version = "1.83"inCargo.tomland updated the README badge to match (was an unenforced1.70+)..github/dependabot.ymlfor weeklycargoandgithub-actionsupdates.Release workflow
cargo publish --allow-dirtyin favor ofcargo publish --locked(the publish job checks out the clean tagged commit).docs/manual-release.mdwhy the automated flow publishes to crates.io after attaching release assets, reconciling it with the manual "publish first" guidance.Docs
watchhas nowalias →linear-cli watch project/teamconfig get/set default_team→ validapi-key/profilekeyshistory LIN-123→history issue LIN-123;metrics -t ENG→metrics velocity ENGdocs/examples.md:ui→interactive,ws→config workspace-*,j→g … --vcs jj, bulkb update→b update-state … -idocs/ai-agents.mdCONTRIBUTING.mdmirroring the exact CI commands.Tests
test_version_commandnow asserts the real crate version viaenv!("CARGO_PKG_VERSION")instead of a stale"0.1"literal.Refactor
Cli,Commands,ConfigCommands, etc.) and shared CLI state out ofsrc/main.rsinto a newsrc/cli.rsmodule, re-exported from the crate root.main.rsshrinks by ~860 lines and becomes the runtime/dispatch entrypoint.Verification
cargo build --locked✅cargo fmt --check✅cargo clippy --locked --all-features -- -D warnings✅cargo test --locked --test cli_tests→ 197 passed ✅commands::api::tests::test_resolve_query_source_none_tty) that hangs only in TTY sandboxes; unrelated to this change.Notes
v0.3.25base after the workspace advanced mid-task; items already addressed upstream (pinnedcross, SHA-pinned actions, corrected README bulk examples) were skipped.