Device Size Support#1232
Merged
Merged
Conversation
# Notes - Added support for plugins to read a board's width (columns) and height (rows) - This allows for plugins to dynamically adjust their content between Flagship (22x6) and Note (15x3) - Example using Date & Time: `Thursday, August 27` (Flagship), `Thu, Aug 27` (Note)
github-actions
Bot
added
patch
backend
dependencies
Signed-off-by: Jason Cox <DarthXoc@users.noreply.github.com>
Contributor
Author
|
@jeffredodd Noticed today that you're working on adding Note array support in #1185. If you're planning on also making that width and height data available to plugins in that PR, I can close this PR and just hold off on updating some plugins that would benefit from having dynamic string sizing support. |
Platform Tests failed on ruff before pytest ran: - B017: assert the specific AttributeError (not blind Exception) for the frozen BoardContext assignment in test_devices.py - I001: sort _DEFAULT_CACHE_KEY into the base import block - ruff format: collapse over-wrapped lines in registry.py and test_plugin_board_context.py (both well under the 120-col limit) ruff 0.15.18 'check' and 'format --check' now pass across src/ plugins/ tests/ scripts/; affected suites (96 tests) green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jeffredodd
approved these changes
Jun 19, 2026
Member
|
@DarthXoc Nah lets get this merged and I can build from it with Arrays! Thanks for contributing! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Docs review
Verdict: looks-good - voice, format, and accuracy all check out.
Checked:
- docs/development/PLUGIN_DEVELOPMENT.md - new Board awareness section: BoardContext attributes (device_type, cols/width, rows/height) verified against src/devices.py at the PR head. Flagship 22x6 / Note 15x3 dimensions match DEVICE_DIMENSIONS. Code example is accurate. Table separator style matches existing PLUGIN_DEVELOPMENT.md style. Reference to plugins/date_time/init.py as a worked example resolves.
- plugins/date_time/README.md - three new rows in the Formatted table plus the follow-on paragraph. Variable names, descriptions, and examples cross-checked against the code and manifest. The *_adaptive / date_pretty descriptions accurately reflect the narrow = board.width < 22 branch in init.py.
- plugins/date_time/docs/SETUP.md - same three rows plus the blockquote callout. Accurate and concise.
No branding confusion (FiestaBoard vs Vestaboard), no PII, no dead links.
Bot: Auto-review by claude-docs-review.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Thursday, August 27(Flagship),Thu, Aug 27(Note)Type of Change
Checklist
Note
I'm a Swift developer, so I'm admittedly using Claude Code quite a bit for this. If you notice anything amiss, just let me know!