fix: Remove duplicate method definitions in QueryCursor #99
+17
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…warnings `init_query_cursor()` had three methods defined twice: - `exec`: `rb_define_module_function` (which internally defines both a singleton and instance method) followed by `rb_define_method` - `match_limit` / `match_limit=`: `DECLARE_ACCESSOR` macro followed by explicit `rb_define_method` calls This produced Ruby warnings on require: warning: method redefined; discarding old exec warning: method redefined; discarding old match_limit warning: method redefined; discarding old match_limit= Fix: - Replace `rb_define_module_function` with `rb_define_singleton_method` for the class-level `exec`, so it no longer conflicts with the instance-level `rb_define_method` - Remove the `DECLARE_ACCESSOR` macro call, keeping the explicit `rb_define_method` calls for `match_limit` and `match_limit=` Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
init_query_cursor()inext/tree_sitter/query_cursor.chad three methods defined twice, producing Ruby warnings onrequire 'tree_sitter':exec:rb_define_module_functioninternally defines both a singleton method and an instance method, thenrb_define_methodredefined the instance method → replaced withrb_define_singleton_methodmatch_limit/match_limit=:DECLARE_ACCESSORmacro and explicitrb_define_methodcalls both defined the same methods → removed theDECLARE_ACCESSORcallTest plan
test/tree_sitter/query_cursor_test.rbthat verifies no "method redefined" warnings are emitted when loading the extensionbundle exec rake compilesucceeds without errors🤖 Generated with Claude Code