Merged
Conversation
* Bumped minimum Cmake version to fix build issues on Cmake 4.0. 3.22 was chosen since that is the version on Ubuntu 22.04 * lowered cmake version to 3.18 for debian bullseye
* add --last-region to manpage * Add shell completions for --last-region
Commit updates appstream data to pass strict validation, which is necessary to build new Flatpak versions.
Flatpak builder added strict validation and requires "developer" information [1] to be provided.
Build error:
```
Run docker run --rm --privileged \
+ flatpak-builder-lint --exceptions repo repo
{
"errors": [
"appstream-missing-developer-name"
],
"warnings": [
"appstream-screenshot-missing-caption"
],
"info": [
"appstream-screenshot-missing-caption: One or more screenshots
are missing captions in the Metainfo file",
"appstream-missing-developer-name: No developer tag found in
Metainfo file"
],
"message": "Please consult the documentation at
https://docs.flathub.org/docs/for-app-authors/linter"
}
error: Recipe `validate-build` failed with exit code 1
```
For good measure, captions for the provided screenshots are added.
After changes made, `appstreamcli validate` only mentions issue with uppercase cid component which should be kept as is:
```sh
$ appstreamcli validate --pedantic data/appdata/org.flameshot.Flameshot.metainfo.xml
P: org.flameshot.Flameshot:7: cid-contains-uppercase-letter org.flameshot.Flameshot
✔ Validation was successful: pedantic: 1
```
[1]: https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines#developer-name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.