Conversation
…ted scripts in PATH scripts directory
… scripts for CASATTA, LSST, and CRACO works
…th MeerTRAP coherent ecsv
profxj
left a comment
profxj
left a comment
There was a problem hiding this comment.
I ignored most of the files in papers/ and focused on the optical modules.
I'm also about to issue a PR to this branch of Claude generated docs
| print("WARNING: no volumetric probability pdv yet calculated") | ||
| exit() | ||
|
|
||
| if self.survey.survey_data.observing.Z_FRACTION is not None: |
There was a problem hiding this comment.
Explain what is going on here
| print("Regenerating MC FRB with too high DM ",frb[1],self.survey.max_dm) | ||
| frb = self.GenMCFRB(Emax_boost) | ||
| if self.survey.max_dmeg is not None: | ||
| while frb[1] > self.survey.max_dm: |
There was a problem hiding this comment.
should this be max_dm or max_dmeg?
| # this defines the ICS FRBs for which we have PATH info | ||
| # notes: FRB20230731A and 'FRB20230718A' are too reddened, so are removed | ||
| # still aiming to follow up frb20240208A and frb20240318A | ||
| frblist=['FRB20180924B','FRB20181112A','FRB20190102C','FRB20190608B', |
There was a problem hiding this comment.
This is pretty hidden in this module. And obscurely named..
and CRAFT specific.. Maybe have it be its own data file?
There was a problem hiding this comment.
Moved it to its own file. In theory, in future we'll have many other FRB lists in there than just ICS! Or, we'll just look for FRBs with that info that exists in survey files, and this old functionality will be deleted. Let's see
| @dataclass | ||
| class Identification(data_class.myDataClass): | ||
| """ | ||
| # parameters for identifying galaxies in an image |
Polish bryce
Polish bryce
3 participants
This is a pretty big one, apologies - all the following works were being co-developed, and could not be nicely separated. It incorporates the following works:
Model of FRB hosts, as described in optical.py, optical_numerics.py, and optical_params.py in the core zdm codebase. This is the core of the work for the updated PATH paper, the calculations for which are given in papers/pathpriors. It also includes data from Nick Loudas - I decided to include his data in the repository, even though it's O~1 MB - in zdm/data/optical/
Calculations for Rubin paper, and initial model of p(m) from Marnoch et al. This is under papers/lsst. The name of the branch inherits from Bryce Smith, who did some Monte Carlo work for this paper. - and named the relevant branch "test".
Calculations for an SKA science chapter, under papers/SKA_science. I was unsure whether or not to keep this in the repository, but felt that having some record of what the SKA thinks it can do could be useful.
CRACO modelling - this contributes to both Jordan's current work, of combining FRB observations from ASKAP into a single effective survey, and also a paper in prep by Andy and I analysing the FRB rate produced by CRACO in various modes.
CASATTA - estimates of CASATTA sensitivity under pspers/casatta for ATNF 2030 Futures meeting. I expect this will continue to be developed as the CASATTA concept becomes more refined