Skip to content

fix(form): show fields only in active languages#57

Merged
mariobehling merged 2 commits into
FOSSASIA-Web:mainfrom
Sak1012:main
Jun 5, 2026
Merged

fix(form): show fields only in active languages#57
mariobehling merged 2 commits into
FOSSASIA-Web:mainfrom
Sak1012:main

Conversation

@Sak1012

@Sak1012 Sak1012 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

this pr adds a fix that avoids showing the field in all the languages and only in the active languages, this also adds a fix for the lead scanning.

Now:
image

Before:
image

Lead Scanning:
image

Copilot AI review requested due to automatic review settings June 4, 2026 07:58

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Sak1012, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts how event is passed into the plugin’s i18n-aware model forms so localized fields can be rendered only for the event’s active languages (instead of for all languages).

Changes:

  • Stop consuming (pop-ing) the event kwarg in I18nModelForm subclasses so it can be forwarded to the base I18nModelForm.
  • Apply the same change to both ExhibitorInfoForm and SponsorGroupForm initializers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mariobehling mariobehling merged commit 4479f8a into FOSSASIA-Web:main Jun 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants