fix(api): update api's for sponosrs#55
Merged
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideEnsures newly resolved sponsor groups are configured to be visible on the front page by default when created via the API. Sequence diagram for sponsor group resolution with front page visibilitysequenceDiagram
actor Organizer
participant Frontend
participant ExhibitionAPI
participant SponsorGroupService
Organizer->>Frontend: Create sponsor with sponsor_group_name
Frontend->>ExhibitionAPI: POST /sponsors
ExhibitionAPI->>ExhibitionAPI: _resolve_sponsor_group(sponsor_group_name, sponsor_group_level)
ExhibitionAPI->>SponsorGroupService: get_or_create(event, name, level, show_on_front_page=True)
SponsorGroupService-->>ExhibitionAPI: SponsorGroup
ExhibitionAPI-->>Frontend: Response including sponsor_group.show_on_front_page = true
Frontend-->>Organizer: Sponsor shown as visible on front page
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Hardcoding
show_on_front_page=Truein_resolve_sponsor_groupremoves flexibility for callers that might want non-front-page sponsor groups; consider passing this as a parameter or deriving it from the context instead.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Hardcoding `show_on_front_page=True` in `_resolve_sponsor_group` removes flexibility for callers that might want non-front-page sponsor groups; consider passing this as a parameter or deriving it from the context instead.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
This pull request updates the exhibition API behavior when auto-creating a SponsorGroup from ExhibitorInfoSerializer by explicitly marking newly created sponsor groups as visible on the event front page.
Changes:
- Set
show_on_front_page=Truewhen creating a newSponsorGroupinside_resolve_sponsor_group.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| event=event, | ||
| name={event.locale or settings.LANGUAGE_CODE: sponsor_group_name}, | ||
| level=sponsor_group_level, | ||
| show_on_front_page=True, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Bug Fixes: