Skip to content

security: remove rusha (SHA-1) dependency#1407

Merged
chhsiao1981 merged 5 commits into
FNNDSC:mainfrom
becush:feat/remove-sha1-rusha-dependency
May 4, 2026
Merged

security: remove rusha (SHA-1) dependency#1407
chhsiao1981 merged 5 commits into
FNNDSC:mainfrom
becush:feat/remove-sha1-rusha-dependency

Conversation

@becush
Copy link
Copy Markdown
Contributor

@becush becush commented Apr 7, 2026

The rusha package is a SHA-1 hashing library listed as a direct dependency but never imported or used anywhere in the source code. Remove it along with its ambient type declaration.

SHA-1 is cryptographically broken and deprecated in favour of the SHA-2 family. No replacement needed as the package was dead code.

BCushing and others added 5 commits April 6, 2026 18:07
The rusha package is a SHA-1 hashing library listed as a direct
dependency but never imported or used anywhere in the source code.
Remove it along with its ambient type declaration.

SHA-1 is cryptographically broken and deprecated in favour of the
SHA-2 family. No replacement needed as the package was dead code.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The rusha package is a SHA-1 hashing library listed as a direct
dependency but never imported or used anywhere in the source code.
Remove it along with its ambient type declaration.

SHA-1 is cryptographically broken and deprecated in favour of the
SHA-2 family. No replacement needed as the package was dead code.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The rusha package is a SHA-1 hashing library listed as a direct
dependency but never imported or used anywhere in the source code.
Remove it along with its ambient type declaration.

SHA-1 is cryptographically broken and deprecated in favour of the
SHA-2 family. No replacement needed as the package was dead code.
@chhsiao1981 chhsiao1981 merged commit 3ed09b5 into FNNDSC:main May 4, 2026
1 check failed
@chhsiao1981
Copy link
Copy Markdown
Contributor

hi @becush

Thank you for your first PR and sorry for the late of the review~

Next time please:

  1. squash into 1 commit (or few significant-different-purposed commits).
  2. update pnpm-lock.yaml as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants