define all the parameter objects to avoid a bug when save.parameters=FALSE#17
Open
donotdespair wants to merge 1 commit into
Open
define all the parameter objects to avoid a bug when save.parameters=FALSE#17donotdespair wants to merge 1 commit into
donotdespair wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Dear Fabian @FK83
This is Tomasz from the University of Melbourne. I happen to have to work with Primiceri's model and I was super glad to find your package. Thanks for this contribution!
Whle working with the package, I noticed a small bug and opened an issue #16. But then to make the code work well for my computations I forked the repo and implemented minimal changes to resolve fix the problem. I got the package working on my side, and thus, I thought I'd contribute. So, here's my PR.
Please feel free to ask any questions. Otherwise, it'd be great if you merged it.
Greetings, Tomasz