Merged
Conversation
Contributor
Author
|
@snissn I am going to merge this. I have been testing xchainClien and it is working fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR focuses on refactor the code base to better implement a configuration-driven approach for the aggregation service, buffer service, client and even deal service, etc.
Codebase Refinements
The update includes substantial code modifications to separate different components into a better go project structure. These changes aim to improve code readability, and maintainability, and easy to add more modular functions in the future. The new structure is:
Configuration Integration for Aggregation Service
When running the xchainClient, we can choose whether to run aggregation or not.
This pull request represents a meaningful step forward in making the xchainClient more configurable and user-friendly, aligning with best practices for scalable application development.
closes #3