Skip to content

GER-585: Create PDP landing page (concept + modern patterns)#26

Open
snissn wants to merge 9 commits intomainfrom
ger-585-pdp-landing-page
Open

GER-585: Create PDP landing page (concept + modern patterns)#26
snissn wants to merge 9 commits intomainfrom
ger-585-pdp-landing-page

Conversation

@snissn
Copy link
Copy Markdown

@snissn snissn commented Feb 16, 2026

Summary

  • expands storage-providers/pdp/README.md into a stable conceptual PDP landing page
  • clarifies what PDP is, when to use it, and what legacy programmatic storage patterns it replaces
  • adds getting-started pointers for modern paths (PDP docs, modern storage patterns, onramps, official FOC/PDP links)
  • fixes global external-link baseline failure by replacing stale eOracle GitBook links in smart-contracts/advanced/oracles.md

Validation

  • npm run check-links

Ticket

@snissn snissn requested review from nijoe1 February 16, 2026 03:40
@snissn snissn changed the base branch from ger-582-remove-deal-client-primary-journeys to main February 20, 2026 02:54
@snissn snissn marked this pull request as draft February 20, 2026 19:22
@snissn snissn marked this pull request as ready for review February 20, 2026 19:22
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 20, 2026

Deploy Preview for timely-kataifi-9f3a09 ready!

Name Link
🔨 Latest commit c0c5c51
🔍 Latest deploy log https://app.netlify.com/projects/timely-kataifi-9f3a09/deploys/6998cf35a939f20008af9499
😎 Deploy Preview https://deploy-preview-26--timely-kataifi-9f3a09.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@snissn
Copy link
Copy Markdown
Author

snissn commented Feb 20, 2026

Content review pass (not just CI) for this PR branch.

Overall: the direction is strong and the PDP landing page itself is useful, but there are several content/format regressions in this branch that should be fixed before merge because this branch is the base for #27/#28/#29.

Findings:

  1. Blocking markdown formatting error
  • smart-contracts/developing-contracts/client-contract-tutorial.md has a malformed list item around the CLI args section (* \piece-cid: gathered from the previous step.`).
  • The opening backtick is not closed, so markdown rendering of that list section is broken.
  1. Blocking malformed link
  • storage-providers/filecoin-deals/auxiliary-services.md has Bacalhau linked as [Bacalhau](https://docs.bacalhau.org/)) (extra ) in link target).
  • This should be corrected to avoid broken rendering/link parse issues.
  1. Blocking front-matter quality issue
  • storage-providers/filecoin-deals/auxiliary-services.md front-matter description appears truncated/incomplete.
  • Current text ends mid-thought and should be completed for metadata quality.
  1. Scope/meaning concern (high)
  • smart-contracts/developing-contracts/README.md is marked with a page-level deprecation warning (DEPRECATED - DO NOT USE).
  • This page is a broad index for smart contract development, and most of its links are still active guidance. Marking the entire page deprecated is likely overbroad and may misdirect users.
  1. Accuracy concern (medium)
  • Same file says legacy direct-deal guidance is documented in PDP.
  • PDP is the replacement path, not legacy reference content. Legacy context should point to legacy/archive/deprecation pages directly.
  1. Messaging consistency concern (medium)
  • storage-providers/pdp/README.md labels PDP as alpha/testing-only, but also describes it as a "stable foundation".
  • Those two claims conflict unless explicitly scoped (e.g., conceptual guidance stable, implementation alpha).
  1. Unrelated content regression in same branch (medium)
  • storage-providers/filecoin-deals/filecoin-programs.md has a Singularity badge link pointing to Spade commit activity.
  • Looks like a copy/paste error; should point to Singularity commit activity.

Recommendation:

@snissn
Copy link
Copy Markdown
Author

snissn commented Feb 20, 2026

GER-585 fix checklist to resume from:

  • Re-scope #26 to ticket-only changes: keep storage-providers/pdp/README.md and smart-contracts/advanced/oracles.md; remove unrelated edits from this PR.
  • Fix malformed markdown in smart-contracts/developing-contracts/client-contract-tutorial.md (unclosed backtick on piece-cid list item).
  • Fix malformed Bacalhau link in storage-providers/filecoin-deals/auxiliary-services.md (...org/)) -> ...org/)).
  • Fix truncated front matter description in storage-providers/filecoin-deals/auxiliary-services.md.
  • Narrow/de-scope the page-level deprecation banner in smart-contracts/developing-contracts/README.md (do not deprecate the entire section).
  • Correct legacy-reference wording in smart-contracts/developing-contracts/README.md (PDP is replacement guidance, not legacy archive).
  • Resolve PDP messaging conflict in storage-providers/pdp/README.md (alpha status vs “stable foundation”).
  • Fix the Singularity badge link target in storage-providers/filecoin-deals/filecoin-programs.md (currently points to Spade commit activity).

When this lands on ger-585-pdp-landing-page, stacked PRs #27#29 will inherit the corrections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant