Skip to content

Fixes to the minimum distance to end of stream when seeking #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myrsloik merged 2 commits into from
Dec 23, 2025
Merged

Fixes to the minimum distance to end of stream when seeking #469

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c0dbb3
Remove workaround for h264 decoder bug
arch1t3cht Aug 29, 2025
a33cd4a
Fix EndOfStreamDist when seeking
arch1t3cht Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/core/videosource.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -919,12 +919,7 @@ bool FFMS_VideoSource::SeekTo(int n, int SeekOffset) {
// Seeking too close to the end of the stream can result in a different decoder delay since
// frames are returned as soon as draining starts, so avoid this to keep the delay predictable.
// Is the +1 necessary here? Not sure, but let's keep it to be safe.
int EndOfStreamDist = CodecContext->has_b_frames + 1;

if (CodecContext->codec_id == AV_CODEC_ID_H264)
// Work around a bug in ffmpeg's h264 decoder where frames are skipped when seeking too
// close to the end in open-gop files: https://trac.ffmpeg.org/ticket/10936
EndOfStreamDist *= 2;
int EndOfStreamDist = Delay.ReorderDelay + Delay.ThreadDelay + 1;

TargetFrame = std::min(TargetFrame, Frames.RealFrameNumber(std::max(0, VP.NumFrames - 1 - EndOfStreamDist)));

Expand Down
Loading