Prevent duplicated related items when updating ResourceDefinition #833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisvang
force-pushed
the
fix/issue830-duplicated-children
branch
from
4dbb17d to
c9f5bcc
Compare
dennisvang
force-pushed
the
fix/issue830-duplicated-children
branch
from
c9f5bcc to
917e60b
Compare
The deletion was un-scheduled because the parent and or child entities still had reference to the link entity. This is now fixed by deleting both sides of the relation (see e.g. hibernate docs on bidirectional many-to-many associations).
…ually link entities), because we need to remove an item from the original list.
Iterate over all default resources. The fdp, catalog and dataset reproduce the duplicated children and the distibution reproduces the duplicated external-links from #830
dennisvang
force-pushed
the
fix/issue830-duplicated-children
branch
from
6c6c5eb to
f78baf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deleteDependentsby clearing both sides of the bidirectional relations for children and external linksfixes #830