-
Notifications
You must be signed in to change notification settings - Fork 11
Upgrade to vue js3 #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Upgrade to vue js3 #231
Conversation
…RDataTeam#198) * add isOptionalBlankNode to fieldUtils * use isOptionalBlankNode in FormRenderer.isList this is ugly, but is the least invasive way to do it we could rename isList to something more fitting * do not add default fields in case of optional blank node * simplify condition for createDefaultValueArray by using isOptionalBlankNode
…ditor (FAIRDataTeam#209) * rename `isOptionalBlankNode` to `isOptionalNode` * check for `sh:NodeShape` instead of `dash:BlankNodeEditor` in `isOptionalNode`
kburger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The font in the rdf preview when creating new metadata is not a monospaced font.
- The issued/modified date(time)picker is not showing the the stylized widget, date selection does work.
- when creating a dataset and setting a theme to
http://example.com, the viewer does not show the url in the list. in advanced search, the sparql query is not syntax-highlighted(not the case in the vue2 version either)
|
Thanks for the PR, but
So many changes in a single commit, out of the blue. I'm not sure how we're supposed to review this... UPDATE: It turns out the bulk of the changed lines is due to package-lock.json: To put things in perspective: the total project is approx. 14110 lines in 171 files |
first and last modified. Theme I see in the list. datepicker was first bootstrap. now I think VueJs one |


Main reason
Security vulnerability fixes with modernization: upgrade to latest Vue.js, enable strict TypeScript, and update styling approach.
What changed
Notes