Skip to content

Conversation

@hcvdwerf
Copy link

Main reason
Security vulnerability fixes with modernization: upgrade to latest Vue.js, enable strict TypeScript, and update styling approach.

What changed

  • Security-related dependency updates and fixes.
  • Vue.js updated to the latest version.
  • TypeScript strict mode enabled with necessary code adjustments.
  • Styling pipeline updated (CSS ordering / build approach) to stabilize theme overrides.

Notes

  • Build and lint pass.
  • Docker runtime config improved for API URL and styling rebuild behavior.

Hans-christian and others added 3 commits January 22, 2026 12:51
…RDataTeam#198)

* add isOptionalBlankNode to fieldUtils

* use isOptionalBlankNode in FormRenderer.isList

  this is ugly, but is the least invasive way to do it

  we could rename isList to something more fitting

* do not add default fields in case of optional blank node

* simplify condition for createDefaultValueArray by using isOptionalBlankNode
…ditor (FAIRDataTeam#209)

* rename `isOptionalBlankNode` to `isOptionalNode`

* check for `sh:NodeShape` instead of `dash:BlankNodeEditor` in `isOptionalNode`
Copy link

@kburger kburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The font in the rdf preview when creating new metadata is not a monospaced font.
  • The issued/modified date(time)picker is not showing the the stylized widget, date selection does work.
  • when creating a dataset and setting a theme to http://example.com, the viewer does not show the url in the list.
  • in advanced search, the sparql query is not syntax-highlighted (not the case in the vue2 version either)

@dennisvang
Copy link
Contributor

dennisvang commented Jan 22, 2026

Thanks for the PR, but

image

So many changes in a single commit, out of the blue.

I'm not sure how we're supposed to review this...

UPDATE:

It turns out the bulk of the changed lines is due to package-lock.json: +5,556 / -22,123 out of +9,429 / -25,517 total
This leaves +3873 / -3394 relevant changes, which may be a little less daunting, but it is still far from reasonable for what is basically a single commit.

To put things in perspective: the total project is approx. 14110 lines in 171 files

@dennisvang dennisvang added the generated Contains AI generated code, a.k.a. Vibe coding label Jan 22, 2026
@hcvdwerf
Copy link
Author

hcvdwerf commented Jan 22, 2026

Thanks for the PR, but

image So many changes in a single commit, out of the blue.

I'm not sure how we're supposed to review this...

Thanks for the feedback. fair point about “out of the blue.” This started as security (required by hospitals) work and then expanded into follow‑ups (Vue 3, TS strictness, styling update, not maintained packages, Docker/runtime config to make it work, and upstream backports). I should’ve communicated earlier.
I agree the PR is too large to review as‑is. Let me know if you have a preferred split.

@hcvdwerf
Copy link
Author

hcvdwerf commented Jan 22, 2026

  • The font in the rdf preview when creating new metadata is not a monospaced font.
  • The issued/modified date(time)picker is not showing the the stylized widget, date selection does work. Not bootstrap anymore
  • when creating a dataset and setting a theme to http://example.com, the viewer does not show the url in the list. Which list? I see it in the top list view
  • in advanced search, the sparql query is not syntax-highlighted (not the case in the vue2 version either) Changed

first and last modified. Theme I see in the list. datepicker was first bootstrap. now I think VueJs one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

generated Contains AI generated code, a.k.a. Vibe coding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants