Conversation
Some request can come without a `To` headers tag (after a 401 for example). This should probably be done only for specific status code.
Contributor
|
I think I like the look at this. Funny enough I was looking at doing the same thing right now. I'll check it out and play with it locally and give you some feedback. On a different note - how comfortable would you be with using python-attrs package? Its not an extra dep for me as I already mix this with aiohttp. |
Open
vodik
reviewed
May 10, 2018
| method, message, local_addr, remote_addr, protocol) | ||
|
|
||
|
|
||
| class AuthDialplan(BaseDialplan): |
Contributor
There was a problem hiding this comment.
I'm okay taking this, but I suspect we don't actually need classes in the public API.
An async generator and closure should be sufficient to capture everything.
Contributor
Author
There was a problem hiding this comment.
I like class because they can be easily subclassed. I'll have to try your proposition make my mind
Contributor
Author
|
I haven't used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick implementation of my idea about dialplan (third commit) by implementing a dialplan that handle authentication.