Skip to content

Update Node Email Titles#550

Merged
ExtremeFiretop merged 2 commits intodevfrom
Node_Emails
Feb 24, 2026
Merged

Update Node Email Titles#550
ExtremeFiretop merged 2 commits intodevfrom
Node_Emails

Conversation

@ExtremeFiretop
Copy link
Copy Markdown
Owner

@ExtremeFiretop ExtremeFiretop commented Feb 24, 2026

Hey @Martinski4GitHub

I'm just going to push this tiny change straight to dev. But I still wanted to create a PR to explain the reasoning for this change.

1. The version I'll bump to 1.6.0

  • I like the fact that in Github it says we currently have 59 releases published and the actual script version is 1.5.9
image
  • It makes logical sense to me, I know it's dumb and makes no real difference, but if we publish 1.5.10 then Github will say we have 60 releases published and the script version number will be 1.5.10 which breaks the nice match we got going on.
  • I would prefer instead if it says 60 releases published and the script version 1.6.0 matches that.

2. I'm changing the email titles for nodes so that it's no longer incorrect.

  • See example below:
image
  • The title was for a ZenWiFi_BQ16 but the body was for a GT-AX6000 which means the title was for wrong in this notification.
  • Because this is a summery email (one email) for multiple nodes with an update, the simplest solution is to just remove the node names from the title.
  • I could also APPEND any node names to the title which has an update, which would also be correct, but it's a more complex solution which would end up just making the title extremely long for people with multiple nodes with updates available.
  • Think:
    Subject: "F/W Update Available for AiMesh Node(s)"
    Instead of appending which would look like:
    Subject: "F/W Update Status for ZenWiFi_BQ16, GT-AX6000, etc, etc, etc"

Update Node Email Titles
Changing Title
@ExtremeFiretop ExtremeFiretop merged commit b0499c9 into dev Feb 24, 2026
7 checks passed
@ExtremeFiretop ExtremeFiretop deleted the Node_Emails branch February 24, 2026 20:36
@Martinski4GitHub
Copy link
Copy Markdown
Collaborator

Hey @Martinski4GitHub

I'm just going to push this tiny change straight to dev. But I still wanted to create a PR to explain the reasoning for this change.

1. The version I'll bump to 1.6.0

* I like the fact that in Github it says we currently have 59 releases published and the actual script version is 1.5.9
image
* It makes logical sense to me, I know it's dumb and makes no real difference, but if we publish 1.5.10 then Github will say we have 60 releases published and the script version number will be 1.5.10 which breaks the nice match we got going on.

* I would prefer instead if it says 60 releases published and the script version 1.6.0 matches that.

Yeah, I get it. It's like a form of numeric OCD regarding the version strings.😉🤜🤛 Go for it!!👍

2. I'm changing the email titles for nodes so that it's no longer incorrect.

* See example below:
image
* The title was for a ZenWiFi_BQ16 but the body was for a GT-AX6000 which means the title was for wrong in this notification.

* Because this is a summery email (one email) for multiple nodes with an update, the simplest solution is to just remove the node names from the title.

* I could also APPEND any node names to the title which has an update, which would also be correct, but it's a more complex solution which would end up just making the title extremely long for people with multiple nodes with updates available.

* Think:
  **Subject: "F/W Update Available for AiMesh Node(s)"**
  Instead of appending which would look like:
  **Subject: "F/W Update Status for ZenWiFi_BQ16, GT-AX6000, etc, etc, etc"**

Yes, the new subject title is absolutely much better and makes more sense in the long run for AiMesh notifications. Good job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants