Support for New AMTM Functionality

[Martinski4GitHub]

• Initial code to support automatic script updates via AMTM.

[Martinski4GitHub]

@ExtremeFiretop,

This PR contains changes & additions to support automatic script updates via AMTM. I have tested as much as I could, but I would not mind a 2nd pair of eyes, so whenever you get a chance, please take a look and validate. There's no hurry, so take your time.

I hope you're having a great weekend, bud.

[ExtremeFiretop]

@ExtremeFiretop,

This PR contains changes & additions to support automatic script updates via AMTM. I have tested as much as I could, but I would not mind a 2nd pair of eyes, so whenever you get a chance, please take a look and validate. There's no hurry, so take your time.

I hope you're having a great weekend, bud.

Wow buddy! Thanks so much!
I appreciate the fact that you took the initiative to help here to get it started. Your a great partner that way!

I myself was more or less waiting for your word on OSR before I started with MerlinAU, but it seems you already got a big chunk of OSR done as well!

Still, if you want me to take on any of the OSR add-ons let me know.

I'll test these changes today, and report back or submit any changes if I notice anything.

Hope you and the wife also have a great weekend! Enjoy some good movies for me 😉 Any recent movie hits I should consider adding to my playlist?

[Martinski4GitHub]

@ExtremeFiretop,
This PR contains changes & additions to support automatic script updates via AMTM. I have tested as much as I could, >>but I would not mind a 2nd pair of eyes, so whenever you get a chance, please take a look and validate. There's no >hurry, >so take your time.
I hope you're having a great weekend, bud.

Wow buddy! Thanks so much! I appreciate the fact that you took the initiative to help here to get it started. Your a great partner that way!

You're welcome. I figured since I had already done most of the AMTM-OSR projects, I could just start the ball rolling with MerlinAU by adding the initial supporting code (similar to what I did for the OSR repos). There might be a few tweaks to make "here and there" based on actual testing with AMTM (once it's ready to call our function).

I myself was more or less waiting for your word on OSR before I started with MerlinAU, but it seems you already got a big chunk of OSR done as well!

Still, if you want me to take on any of the OSR add-ons let me know.

I've done all of the AMTM-OSR projects except for FlexQoS, which I'm not familiar with. The JackYaz projects were fairly simple and straightforward to change since they all use the same template and structure, so after I completed one repo, I just did a "Copy & Paste" for the others (with some minor tweaks).

Since you've taken charge of the FlexQoS repo and know the code well enough to make changes, I'll leave that to you for whenever you get a chance.

I'll test these changes today, and report back or submit any changes if I notice anything.

Sounds good, but take your time since AMTM might not be ready for about 3 weeks (based on the most recent thelonelycoder messages).

Hope you and the wife also have a great weekend! Enjoy some good movies for me 😉 Any recent movie hits I should consider adding to my playlist?

Thanks!! My wife and I are doing well, and we have been enjoying our weekly "movie nights" (sometimes 2 or 3 times a week :>). Recently, we watched "The Gorge" and "F1". Also, some of Apple TV series: Hijack, Severance, and Silo.
We've been hooked on those series.

Have a good week, bud. We'll talk some more later.

[ExtremeFiretop]

Without Auto Updates Enabled:

With Auto Updates Enabled:

All seems to work well so far!
Thanks again @Martinski4GitHub

All I had to do so far was update the version.txt file.

[ExtremeFiretop]

Question for you @Martinski4GitHub

How do you feel about this request?
https://www.snbforums.com/threads/merlinau-v1-5-9-the-ultimate-firmware-auto-updater.96306/post-985278

[ExtremeFiretop]

Thanks!! My wife and I are doing well, and we have been enjoying our weekly "movie nights" (sometimes 2 or 3 times a week :>). Recently, we watched "The Gorge" and "F1". Also, some of Apple TV series: Hijack, Severance, and Silo. We've been hooked on those series.

I've put all these in my playlist to watch BTW ;) Thanks for the suggestions!

[Martinski4GitHub]

Without Auto Updates Enabled:

With Auto Updates Enabled:

All seems to work well so far! Thanks again @Martinski4GitHub

All I had to do so far was update the version.txt file.

Excellent!!! Thank you for taking the time to test and validate the PR changes. Looks like we're good to go once AMTM is ready to integrate the new functionality.

[Martinski4GitHub]

Question for you @Martinski4GitHub

How do you feel about this request? https://www.snbforums.com/threads/merlinau-v1-5-9-the-ultimate-firmware-auto-updater.96306/post-985278

I took a brief look at the website (https://docs.ntfy.sh/), and it seems interesting. However, I don't like that the "topics" (i.e. channels), one subscribes to are completely public, unsecured, and unprotected from any prying eyes, so for that alone I wouldn't use this service for my own personal notifications, and I don't know if they are collecting/mining data from the notifications themselves (I'm not too paranoid, but paranoid enough... 😉).

OTOH, if the notifications being sent have no personally identifiable information, and no other type of data that the user might consider "private" - none whatsover - in their own eyes, I suppose the service could be used for MerlinAU notifications with complete disregard to security and/or privacy.

Now, I know the documentation has instructions to self-host your own ntfy server and create a fully private notification channel, but most SNB Forum users don't appear to be tech-savvy enough to do this on their own, so they would follow "the path of least resistance."

The setup and actual call to the service appear fairly simple, so I don't think that part of the implementation is a major undertaking. I suspect most of the work would involve modifying existing code to "reformat & redirect" all the current email notifications to the new notification service.

WRT options, I imagine users will want to configure one of four scenarios:

1. Disable ALL notifications
2. Send Notifications ONLY via Email
3. Send Notifications ONLY via Ntfy
4. Send Notifications via BOTH Email and Ntfy

Now, I expect that adding this new notification service may open the door for requests to add support for Pushover and maybe even Discord as well... 🤷🏻‍♂️

To make a long story short: I'm not completely opposed to adding this ntfy service to MerlinAU, but I do have my own personal reservations, so it's not something I would recommend to family or close friends with full confidence.

Just my 2 cents.

[ExtremeFiretop]

Question for you @Martinski4GitHub
How do you feel about this request? https://www.snbforums.com/threads/merlinau-v1-5-9-the-ultimate-firmware-auto-updater.96306/post-985278

I took a brief look at the website (https://docs.ntfy.sh/), and it seems interesting. However, I don't like that the "topics" (i.e. channels), one subscribes to are completely public, unsecured, and unprotected from any prying eyes, so for that alone I wouldn't use this service for my own personal notifications, and I don't know if they are collecting/mining data from the notifications themselves (I'm not too paranoid, but paranoid enough... 😉).

OTOH, if the notifications being sent have no personally identifiable information, and no other type of data that the user might consider "private" - none whatsover - in their own eyes, I suppose the service could be used for MerlinAU notifications with complete disregard to security and/or privacy.

Now, I know the documentation has instructions to self-host your own ntfy server and create a fully private notification channel, but most SNB Forum users don't appear to be tech-savvy enough to do this on their own, so they would follow "the path of least resistance."

Totally agree with all the privacy points, I myself also would not consider such a service, but I think we would lose that argument due to the fact that the notifications themselves can be made with no personally identifiable information (as you mentioned) or host that a private instance.

The setup and actual call to the service appear fairly simple, so I don't think that part of the implementation is a major undertaking. I suspect most of the work would involve modifying existing code to "reformat & redirect" all the current email notifications to the new notification service.

WRT options, I imagine users will want to configure one of four scenarios:

1. Disable ALL notifications
2. Send Notifications ONLY via Email
3. Send Notifications ONLY via Ntfy
4. Send Notifications via BOTH Email and Ntfy

Now, I expect that adding this new notification service may open the door for requests to add support for Pushover and maybe even Discord as well... 🤷🏻‍♂️

This is the real show stopper for me. I don't want to start to integrate into every service imaginable.
We do this, and we open the door to everything else. Which is my real concern and the main reason I'm not overly a fan of the idea.

To make a long story short: I'm not completely opposed to adding this ntfy service to MerlinAU, but I do have my own personal reservations, so it's not something I would recommend to family or close friends with full confidence.

Just my 2 cents.

We are in agreeance then for now. No need to investigate more for the time being. :)

[ExtremeFiretop]

I've done all of the AMTM-OSR projects except for FlexQoS, which I'm not familiar with. The JackYaz projects were fairly simple and straightforward to change since they all use the same template and structure, so after I completed one repo, I just did a "Copy & Paste" for the others (with some minor tweaks).

I've finished FlexQoS and created the PR here:
https://github.com/AMTM-OSR/FlexQoS/pull/35/changes

Same as you, it was mostly a copy and paste job except for a few changes to the "install" function to allow a completely "non-interactive" install. It seemed pretty simple and appears to work correctly in my tests I performed.