fix: low-risk bug hunt — Tier A (11 verified fixes)

client/src/lib/directorTaskNotice.test.mjs

@@ -0,0 +1,44 @@
+import test from "node:test";
+import assert from "node:assert/strict";
+
+import { parseDirectorTaskNotice } from "./directorTaskNotice.ts";
+
+test("parseDirectorTaskNotice keeps a valid open_structured_outline action", () => {
+  const result = parseDirectorTaskNotice({
+    taskNotice: {
+      code: "CHAPTER_TITLE_DIVERSITY",
+      summary: "章节标题重复，需要修复。",
+      action: {
+        type: "open_structured_outline",
+        label: "去修复",
+        volumeId: "vol-1",
+      },
+    },
+  });
+
+  assert.ok(result);
+  assert.ok(result.action);
+  assert.equal(result.action.type, "open_structured_outline");
+  assert.equal(result.action.label, "去修复");
+  assert.equal(result.action.volumeId, "vol-1");
+});
+
+test("parseDirectorTaskNotice rejects an action with an unknown type instead of forcing it", () => {
+  const result = parseDirectorTaskNotice({
+    taskNotice: {
+      code: "CHAPTER_TITLE_DIVERSITY",
+      summary: "章节标题重复，需要修复。",
+      // Untrusted server data carrying an action type that is NOT in the allowed union.
+      action: {
+        type: "redirect_to_evil_site",
+        label: "点我",
+        volumeId: "vol-9",
+      },
+    },
+  });
+
+  assert.ok(result, "notice itself stays valid (code + summary present)");
+  // The current tautology silently coerces ANY type to "open_structured_outline".
+  // An unknown/untrusted action type must be dropped, not laundered into a valid one.
+  assert.equal(result.action, null);
+});

client/src/lib/directorTaskNotice.ts

@@ -22,8 +22,9 @@ export function parseDirectorTaskNotice(meta: Record<string, unknown> | null | u
     code: notice.code.trim(),
     summary: notice.summary.trim(),
     action: notice.action && typeof notice.action === "object"
+      && notice.action.type === "open_structured_outline"
       ? {
-        type: notice.action.type === "open_structured_outline" ? "open_structured_outline" : "open_structured_outline",
+        type: "open_structured_outline",
         label: typeof notice.action.label === "string" && notice.action.label.trim()
           ? notice.action.label.trim()
           : "快速修复章节标题",

client/src/pages/creativeHub/hooks/useCreativeHubRuntime.ts

@@ -442,6 +442,11 @@ export function useCreativeHubRuntime({
       }] : []);
       setThreadStateLoaded(true);
       currentRunIdRef.current = state.latestTurnSummary?.runId ?? null;
+    }).catch((error) => {
+      if (disposed) return;
+      // Surface the failure and unstick the UI instead of leaving it on the loading state forever.
+      setThreadStateLoaded(true);
+      toast.error(error instanceof Error ? error.message : "加载会话历史失败，请稍后重试。");
     });
     return () => {
       disposed = true;

client/src/pages/novels/components/cover/NovelCoverDialog.tsx

@@ -605,7 +605,7 @@ export function NovelCoverDialog(props: NovelCoverDialogProps) {
                         type="button"
                         size="sm"
                         variant="outline"
-                        disabled={asset.isPrimary || setPrimaryMutation.isPending || deleteAssetMutation.variables === asset.id}
+                        disabled={asset.isPrimary || setPrimaryMutation.isPending || (deleteAssetMutation.isPending && deleteAssetMutation.variables === asset.id)}
                         onClick={() => setPrimaryMutation.mutate(asset.id)}
                       >
                         {asset.isPrimary ? "当前主封面" : "设为当前封面"}
@@ -614,14 +614,14 @@ export function NovelCoverDialog(props: NovelCoverDialogProps) {
                         type="button"
                         size="sm"
                         variant="destructive"
-                        disabled={deleteAssetMutation.variables === asset.id}
+                        disabled={deleteAssetMutation.isPending && deleteAssetMutation.variables === asset.id}
                         onClick={() => {
                           void handleDeleteAsset(asset).catch((error) => {
                             window.alert(getErrorMessage(error, "删除封面失败，请稍后重试。"));
                           });
                         }}
                       >
-                        {deleteAssetMutation.variables === asset.id ? "删除中..." : "删除"}
+                        {deleteAssetMutation.isPending && deleteAssetMutation.variables === asset.id ? "删除中..." : "删除"}
                       </Button>
                     </div>
                   </div>

client/src/pages/worlds/WorldWorkspace.tsx

@@ -491,12 +491,14 @@ export default function WorldWorkspace() {
               })
             }
             onInjectLibraryField={(libraryId) =>
-              void useWorldLibraryItem(libraryId, { worldId: id, targetField: selectedLayerMeta.primaryField }).then(
-                () => invalidateWorld(),
-              )
+              void useWorldLibraryItem(libraryId, { worldId: id, targetField: selectedLayerMeta.primaryField })
+                .then(() => invalidateWorld())
+                .catch((error) => toast.error(error instanceof Error ? error.message : "引用素材到字段失败。"))
             }
             onInjectLibraryStructure={(libraryId, targetCollection) =>
-              void useWorldLibraryItem(libraryId, { worldId: id, targetCollection }).then(() => invalidateWorld())
+              void useWorldLibraryItem(libraryId, { worldId: id, targetCollection })
+                .then(() => invalidateWorld())
+                .catch((error) => toast.error(error instanceof Error ? error.message : "引用素材到结构失败。"))
             }
             onPublishLibrary={() => publishLibraryMutation.mutate()}
             onCreateSnapshot={() => snapshotCreateMutation.mutate()}

client/src/pages/writingFormula/useWritingFormulaCreateFlow.ts

@@ -182,6 +182,9 @@ export function useWritingFormulaCreateFlow({
       resetCreateFlow();
       void refreshStyleData().then(() => {
         onAutoSavedProfileReady(profileId, `写法“${profileName}”已自动保存，已经为你打开当前写法编辑。`);
+      }).catch(() => {
+        // The profile is already saved server-side; still open the editor even if the list refresh failed.
+        onAutoSavedProfileReady(profileId, `写法“${profileName}”已自动保存，但刷新写法列表失败，请稍后手动刷新。`);
       });
       return;
     }