Skip to content

[Home Page] Add a simple onboarding slot to Home, focused on "manage my team" intent#86663

Open
adamgrzybowski wants to merge 8 commits intoExpensify:mainfrom
software-mansion-labs:@adamgrzybowski/onboarding-home
Open

[Home Page] Add a simple onboarding slot to Home, focused on "manage my team" intent#86663
adamgrzybowski wants to merge 8 commits intoExpensify:mainfrom
software-mansion-labs:@adamgrzybowski/onboarding-home

Conversation

@adamgrzybowski
Copy link
Copy Markdown
Contributor

@adamgrzybowski adamgrzybowski commented Mar 30, 2026

Explanation of Change

Adds a "Getting started" onboarding checklist widget to the Home page for users with the "manage my team" onboarding intent. The section appears in the right column on desktop and guides new users through key setup steps with a checkbox-style UI.

Visibility rules:

  • Only shown for users who selected the "manage my team" onboarding intent.
  • Only shown for active trials within 60 days of the trial start date.
  • Requires an active policy to be set.

Checklist items (up to 4):

  1. Create a workspace — always shown, always marked complete (gives momentum). Navigates to workspace overview.
  2. Connect to [accounting system] — shown if the user selected a direct-connect integration (QBO, QBD, Xero, NetSuite, Sage Intacct) during onboarding. Checked when the workspace has a successful connection. OR Customize accounting categories — shown otherwise. Checked when the workspace has at least one non-default category.
  3. Link company cards — shown if company cards are enabled on the workspace. Navigates to company cards settings.
  4. Set up spend rules — shown if rules are enabled on the workspace. Checked when the workspace has any non-default rule.

Each row is fully clickable and navigates to the relevant workspace editor route. Completed items show a filled checkmark; incomplete items show an empty checkbox with an arrow icon.

Fixed Issues

$ #86288

Tests

  1. Log in with a new account that selected "manage my team" during onboarding and is within the free trial period
  2. Navigate to the Home page
  3. Verify the "Getting started" section appears in the right column (desktop) with up to 4 checklist items
  4. Verify "Create a workspace" is always shown and checked off
  5. If you selected a direct-connect accounting integration (e.g., QuickBooks Online), verify the second item reads "Connect to QuickBooks Online" and navigates to /accounting in the workspace editor
  6. If you selected "None" or a non-direct integration, verify the second item reads "Customize accounting categories" and navigates to /categories
  7. Click on an incomplete checklist item and verify it navigates to the correct workspace editor route
  8. Verify completed items show a filled checkmark and incomplete items show an empty checkbox with an arrow
  9. Verify the section does NOT appear for users who did not select "manage my team" intent
  10. Verify the section does NOT appear for users whose trial started more than 60 days ago
  11. On mobile (narrow layout), verify the section renders correctly with appropriate padding
  • Verify that no errors appear in the JS console

Offline tests

  1. Go to the Home page while online and verify the "Getting started" section renders
  2. Switch to offline mode
  3. Verify the section still renders with the last known data (checklist items based on cached Onyx state)
  4. Click a checklist item while offline and verify the navigation still works locally

QA Steps

Same as Tests.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-03-30.at.17.44.21.mov

@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Mar 30, 2026

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@adamgrzybowski adamgrzybowski marked this pull request as ready for review March 30, 2026 15:46
@adamgrzybowski adamgrzybowski requested review from a team as code owners March 30, 2026 15:46
@melvin-bot melvin-bot bot requested review from ZhenjaHorbach and heyjennahay and removed request for a team March 30, 2026 15:46
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Mar 30, 2026

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team March 30, 2026 15:46
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 86257b0e54

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants