[Onyx Audit] Migrate keys to RAM-only part 3/3

[JKobrynski]

…tWithStoredValues, add initial state

Explanation of Change

Coming from this comment. The main goal of this PR is to remove initWithStoredValues from keys that turned out to be more problematic than anticipated during migration part 1. At the moment, it's about migrating the following keys:

• IS_CHECKING_PUBLIC_ROOM

Disclaimer:

"Migration" doesn't mean that keys need to be migrated to RAM-only, it means we should remove initWithStoredValues param from their calls and consider whether or not they should be migrated or not (and apply adjustments if necessary to maintain functionality).

Fixed Issues

$ #80091
PROPOSAL: N/A

Tests

1. App Launch (no deep link)

1. Open the app normally (no deep link)
2. Confirm the splash screen disappears and you land on the home screen without hanging
3. Kill and restart the app
4. Confirm the splash screen disappears again on restart — no stale state persists

2. Deep link to a public room — logged out

1. Log out of the app (or use a fresh install)
2. Open a deep link to a public room (e.g. a shared report link like new-expensify://r/<publicRoomReportID>)
3. Confirm the app correctly navigates to the public room or shows the sign-in page
4. Confirm the splash screen does not hang — it should disappear once navigation loads

3. Deep link to a public room — logged in

1. Log in to the app
2. Navigate to the home screen
3. Open a deep link to a public room
4. Confirm you are taken directly to the report
5. Kill and restart the app, then repeat — confirm deep link still works after restart

4. Deep link to a private room — logged out

1. Log out of the app
2. Open a deep link to a private room (one you don't have access to without logging in)
3. Confirm you are redirected to the sign-in page
4. Confirm the splash screen does not hang

5. Deep link to a report — logged in

1. Log in to the app
2. Navigate back to the home screen
3. Open a deep link to a report you have access to
4. Confirm you navigate directly to the report without any splash screen hang or delay

6. Offline behavior

1. Enable airplane mode / disconnect from network
2. Open the app (cold start)
3. Confirm the splash screen disappears and the app loads (offline mode)
4. If a deep link was used, confirm the sign-in page is shown (not a forever-loading splash)
5. Disable airplane mode and confirm the app reconnects normally

7. Sign out and sign back in

1. Log in to the app, navigate around
2. Log out
3. Confirm the app returns to the sign-in page without the splash screen getting stuck
4. Log back in
5. Confirm the app loads normally — no stale state from the previous session

8. HybridApp (if applicable)

1. Open the app in HybridApp mode (OldDot + NewDot combined)
2. Transition from OldDot to NewDot
3. Confirm the splash screen disappears and NewDot loads correctly
4. Open a deep link while in HybridApp mode
5. Confirm the deep link navigates to the correct report
6. Kill and restart the HybridApp — confirm no splash screen hang on restart

• Verify that no errors appear in the JS console

Offline tests

1. Enable airplane mode / disconnect from network
2. Open the app (cold start)
3. Confirm the splash screen disappears and the app loads (offline mode)
4. If a deep link was used, confirm the sign-in page is shown (not a forever-loading splash)
5. Disable airplane mode and confirm the app reconnects normally

QA Steps

Same as Tests section above

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari