Fix: Focus jumps to Concierge Anywhere (SidePanel) when switching chats in the Inbox#86658
Draft
jmusial wants to merge 2 commits intoExpensify:mainfrom
Draft
Fix: Focus jumps to Concierge Anywhere (SidePanel) when switching chats in the Inbox#86658jmusial wants to merge 2 commits intoExpensify:mainfrom
jmusial wants to merge 2 commits intoExpensify:mainfrom
Conversation
Contributor
Author
|
@codex review |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
On large screens, two
ComposerWithSuggestionsinstances can be mounted simultaneously — one for the active report and one for Concierge Anywhere.When a secondary input (e.g. search bar, emoji picker) is opened, focused and then closed, both composers would re-register their navigation focus listeners, causing the composer that registered later to "steal" keyboard focus from the active one.
Fix: A guard is added at the top of the navigation listener
useEffect, scoped toisExtraLargeScreenWidth— the only layout where two composers coexist. If the running composer is not the one currently tracked byReportActionComposeFocusManager.composerRef, it skips registering its listeners entirely, preventing the focus takeover.Fixed Issues
$
PROPOSAL:
Tests
Magnifying glassicon to open search modal, type somethingEscto dismiss the modalOffline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari