Open
Conversation
Contributor
Author
daw538
reviewed
Sep 13, 2024
| !s Adding relative humidity calculation so as to allow comparison with Frierson's thesis. | ||
|
|
||
| if(id_rh >0) then | ||
| call rh_calc (p_full(:,:,:,previous),tg_tmp,qg_tmp,RH) |
Contributor
There was a problem hiding this comment.
Was the function call meant to be inside the if statement all along then??
Contributor
|
Broadly looks fine to me. Most of the code is adding functionality rather than editing the existing model so happy to okay if it works as intended. Probably don't need the lines that comments simply stating |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds thermodynamic sea ice code following Zhang et al. (2022).
Test case can be found here: exp/test_cases/thermodynamic_sea_ice/grey_thermo_ice_test_case.py