[Bug] internvl3 duplicate <image> token issue #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request directly attempts to address the issue at #998
Summary
This PR fixes a bug in the InternVL3 model integration where the![]()
token was being inserted twice in certain prompting scenarios. This redundancy could lead to incorrect model behavior or input format errors.
Details of Changes
Modified the logic in models/simple/internvl3.py to prevent appending an extra![]()
token if one is already present in the prompt template.
Ensured that the input passed to the tokenizer contains exactly one image placeholder per image.
Test Plan