Skip to content

[TASK] Add SpatialTreeBench task #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
loongfeili wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[TASK] Add SpatialTreeBench task #994

loongfeili wants to merge 3 commits into from

Conversation

@loongfeili
Copy link
Contributor

@loongfeili loongfeili commented Jan 14, 2026

aaa_tmp

Copilot AI review requested due to automatic review settings January 14, 2026 13:37
Copilot AI reviewed Jan 14, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@loongfeili
Copy link
Contributor Author

loongfeili commented Jan 15, 2026

@copilot open a new pull request to apply changes based on the comments in this thread

@loongfeili
Copy link
Contributor Author

loongfeili commented Jan 15, 2026

@kcz358

@loongfeili
Copy link
Contributor Author

loongfeili commented Jan 16, 2026

@PeterWangyi

kcz358
kcz358 reviewed Jan 16, 2026
View reviewed changes
Copy link
Collaborator

@kcz358 kcz358 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please correct me if I am wrong. Seems like the utils.py only depends on metrics/rule_metrics.py and rule_metrics.py does not depends on other part of the mindcude_cogmap? Does this mean we can remove the mindcube_cogmap folder?

@loongfeili
Copy link
Contributor Author

loongfeili commented Jan 16, 2026

Yes, utils.py depends on metrics/rule_metrics.py, but the cogmapeval function inside it relies on the mindcube_cogmap directory.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kcz358 kcz358 kcz358 left review comments

Copilot code review Copilot Copilot left review comments

@PeterWangyi PeterWangyi Awaiting requested review from PeterWangyi

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@loongfeili @kcz358