fix: increment revision on updateMarks to preserve CAS invariant#9
Open
tmchow wants to merge 1 commit intoEveryInc:mainfrom
Open
fix: increment revision on updateMarks to preserve CAS invariant#9tmchow wants to merge 1 commit intoEveryInc:mainfrom
tmchow wants to merge 1 commit intoEveryInc:mainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
densign01
added a commit
to densign01/proof-sdk
that referenced
this pull request
Mar 16, 2026
Port PR EveryInc#23: set terminalCloseReason in authenticationFailed handler so expired collab tokens (5 min TTL) trigger auto-reconnect instead of silently dropping agent edits. Port PR EveryInc#9: increment revision in setMarks SQL so marks updates maintain the compare-and-swap invariant for concurrent agent edits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
updateMarksinserver/db.tsupdatedmarksandupdated_atbut never incrementedrevision:Every other write path (
updateDocumentAtomic,updateDocumentAtomicByRevision) incrementsrevision.updateMarksdid not.Impact
The
edit/v2endpoint usesbaseRevisionas a CAS lock viaupdateDocumentAtomicByRevision. Because marks mutations leftrevisionunchanged, an agent could:revision = Nrevision = Nedit/v2withbaseRevision = N— CAS check passes on a stale baseFix
Added
revision = revision + 1to theupdateMarksSQL inserver/db.ts, consistent with all other write paths.