fix: stabilize collection route refresh and recent activity#64
Open
Snepsid wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetch_eventsContext
While browsing the live upstream production marketplace UI, I noticed collection pages could get into a stale or partially-loaded state when moving between collections.
The main symptoms I saw were:
For Sale,All, or owned item data from the previous collection visibleThis appears to be a combination of route reuse/state timing issues and slower Recent Activity queries. The UI can reuse the same mounted route component while only the slug changes, so collection-specific state needs to be cleared/refreshed explicitly. Separately,
fetch_eventsbenefits from indexes that match the collection activity lookup pattern.Notes
This branch is based directly on
upstream/developmentand intentionally excludes unrelated attribute-order/main-traits work.Testing
git diff --checkmarketplace/src/environments/environment.ts