Skip to content

fix: stabilize collection route refresh and recent activity#64

Open
Snepsid wants to merge 3 commits into
Ethereum-Phunks:developmentfrom
nakamingos:fix/upstream-market-route-state-refresh
Open

fix: stabilize collection route refresh and recent activity#64
Snepsid wants to merge 3 commits into
Ethereum-Phunks:developmentfrom
nakamingos:fix/upstream-market-route-state-refresh

Conversation

@Snepsid
Copy link
Copy Markdown

@Snepsid Snepsid commented May 15, 2026

Summary

  • clear collection-specific market state when switching collection routes so stale listings/items do not remain visible
  • refresh the active collection when either collections or the active slug changes
  • ignore stale recent-activity responses when switching collections quickly
  • add retry/error logging around recent activity and collection preview RPC calls
  • add indexes for collection recent-activity queries used by fetch_events

Context

While browsing the live upstream production marketplace UI, I noticed collection pages could get into a stale or partially-loaded state when moving between collections.

The main symptoms I saw were:

  • switching from one collection to another could leave stale For Sale, All, or owned item data from the previous collection visible
  • Recent Activity sometimes stayed blank until refreshing the page or navigating away and back
  • on larger collections, Recent Activity could be noticeably slow to populate
  • occasionally the collections dropdown did not populate on first load until a refresh
  • repeated fast collection switching made the stale/blank states easier to reproduce

This appears to be a combination of route reuse/state timing issues and slower Recent Activity queries. The UI can reuse the same mounted route component while only the slug changes, so collection-specific state needs to be cleared/refreshed explicitly. Separately, fetch_events benefits from indexes that match the collection activity lookup pattern.

Notes

This branch is based directly on upstream/development and intentionally excludes unrelated attribute-order/main-traits work.

Testing

  • Reproduced similar behavior while switching quickly between collections
  • Verified the route/state refresh and Recent Activity behavior locally after the changes
  • git diff --check
  • TypeScript check was not run successfully because this clean upstream branch does not include a local generated marketplace/src/environments/environment.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant