Support ordered main traits#63
Open
Snepsid wants to merge 1 commit into
Open
Conversation
Snepsid
force-pushed
the
feature/main-traits-priority
branch
from
2cef03c to
8abd29a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for
mainTraitsas an ordered list instead of a singlemainTrait.This lets collections define fallback traits for the item header rarity display. For example, a collection can use
Typefirst, but fall back toNamefor special items that do not have aTypetrait, without makingNamefilterable or muddying up trait counts.Changes
collections.mainTraittocollections.mainTraits text[]mainTraitsNamewhen no main traits are configuredTesting