Skip to content

Fix message deduplication when double puppeting is enabled + memory leak#8

Open
CarlAmbroselli wants to merge 1 commit into
EthanRDoesMC:mainfrom
CarlAmbroselli:dedupe
Open

Fix message deduplication when double puppeting is enabled + memory leak#8
CarlAmbroselli wants to merge 1 commit into
EthanRDoesMC:mainfrom
CarlAmbroselli:dedupe

Conversation

@CarlAmbroselli

@CarlAmbroselli CarlAmbroselli commented Dec 4, 2021

Copy link
Copy Markdown
  • Comparing IMMessage with each other won't work, we need to compare the GUID
  • Fix memory leak that would grow the list of GUID to compare indefinitely and limit the array to 10 GUIDs
  • Improve prefixes for logging to enable easier greping

@CarlAmbroselli

Copy link
Copy Markdown
Author

@EthanRDoesMC I know brooklyn isn't actively developed anymore, but mind merging the two PRs and cutting one more release?

@EthanRDoesMC

EthanRDoesMC commented Feb 28, 2022

Copy link
Copy Markdown
Owner

Can you give me until spring break (~mar 13)? I'll branch off my current un-pushed changes and then anyone who wants to combine them can.

@CarlAmbroselli

Copy link
Copy Markdown
Author

Thanks Ethan, sounds good!

@rufflepot

Copy link
Copy Markdown

Just checking in and seeing if there are still plans on merging this deduplication fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants